Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an obsolete skin/resource file is temporarily locked, incremental sync and its full-ZIP fallback previously treated the failed deletion as success and recorded the new repository SHA. The obsolete file was then never retried.
Count failed removals (including renamed source files) alongside extraction failures and keep the previous SHA until all files synchronize. Preserve
.skin_versionduring cleanup so a failed full sync cannot erase the previous marker. Reset failure accounting for each extraction, allowing the next successful full retry to record its SHA.Validation: six focused regression tests fail against
146f7986and pass with this change, covering removal/rename callers, full fallback, successful retry and cleanup counts.python -B -m unittest discover -s utils/tests -t .: 52 tests pass with temporary LOCALAPPDATA. Ruff E9/F63/F7/F82 andgit diff --checkpass. No network or live game required by the new tests.