Repository navigation
fix(monitor): release processes acquired during cancellation - #376
Merged
Alban1911 merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup, overlay startup, or skipped injection can cancel the monitor while process suspension is still in flight. Previously cancellation missed the unpublished process and the worker could exit leaving it suspended. Both discovery paths now publish under the cancellation lock or resume the locally owned process when cancellation wins. Slow process operations remain outside the lock. Cancellation takes ownership atomically, and completion of an older resume cannot erase a restarted monitor's state. A failed local release remains available for the existing cleanup retry; timeout callback failures also release acquired processes.
Validation:
python -B -m unittest injection.tests.test_game_monitor_cancellation -v(7 passing, including 18 Event-controlled cancellation scenarios across both discovery paths and all three cancellation entry points); isolated injection discovery (62 passing); all 323 Python tests passed in the combined audit worktree; CI error-only Ruff 0.16.8 andgit diff --checkpassed. Against unpatched HEAD, the during-suspension regression fails in all six path/cancellation combinations. New regressions mock process operations; no live-game validation was performed.