Sanitize derived project IDs#2163
Open
KairosOps wants to merge 1 commit into
Open
Conversation
KairosOps
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1877.
This keeps project IDs derived from local paths on the same path as configured project IDs. A directory like
llama.cppnow registers asllama-cppinstead of writing a dotted key into config, and the flat-config registration path uses the same helper.Checked locally:
pnpm install --frozen-lockfile --ignore-scriptspnpm --filter @aoagents/ao-cli... buildpnpm --filter @aoagents/ao-cli test -- __tests__/commands/start.test.tspnpm --filter @aoagents/ao-cli typecheckpnpm exec eslint packages/cli/src/commands/start.ts packages/cli/__tests__/commands/start.test.tsgit diff --check origin/main..HEADI used
--ignore-scriptsonly to avoid the local Windows native rebuild step; the relevant workspace packages were built before running the CLI checks.