Skip to content

Document plain-shell orchestration in orchestrating-agent-relay#88

Open
willwashburn wants to merge 3 commits into
mainfrom
orchestrating-plain-shell-sends
Open

Document plain-shell orchestration in orchestrating-agent-relay#88
willwashburn wants to merge 3 commits into
mainfrom
orchestrating-plain-shell-sends

Conversation

@willwashburn

@willwashburn willwashburn commented Jul 22, 2026

Copy link
Copy Markdown
Member

The orchestrating skill covers the session that has no relay MCP configured: channel reads are credential-free (message list returns newest first, [] when empty), sends require an agent token — minted once via agent-relay agent register orchestrator --type system and stored inside the gitignored broker state dir — and a backgrounded node tail | grep -m1 pipeline serves as a push-style wake-up trigger on relay_inbound events (with the durable read still going through check_inbox/list_messages). Two matching troubleshooting rows cover the requires agentToken or agentClient failure and monitors that miss DONE posts due to newest-first ordering.

Every command and error string is verified against a live v11 broker orchestrating a two-worker team.

🤖 Generated with Claude Code

Review in cubic

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@willwashburn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 72c099c8-7bb4-49cb-9d57-75058c9d1da7

📥 Commits

Reviewing files that changed from the base of the PR and between 12a82cc and f015c48.

📒 Files selected for processing (1)
  • skills/orchestrating-agent-relay/SKILL.md
📝 Walkthrough

Walkthrough

The relay skill documentation adds plain-shell orchestrator token setup, push-style DONE monitoring with node tail, durable message-reading guidance, and troubleshooting entries for send authentication and event matching.

Changes

Relay orchestration guidance

Layer / File(s) Summary
Plain-shell sending setup
skills/orchestrating-agent-relay/SKILL.md
Documents credential-free reads, orchestrator token registration, token persistence, and token handling precautions.
Push monitoring and troubleshooting
skills/orchestrating-agent-relay/SKILL.md
Adds a node tail wake-up pattern for DONE events and explains durable message reads, token failures, ordering, and relay_inbound.body matching.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • AgentWorkforce/skills#85: Updates the same relay skill with overlapping node tail, DONE matching, and durable-message guidance.

Suggested reviewers: khaliqgant

Poem

I’m a rabbit with tokens tucked tight,
Shell sends now hop through the night.
Tail wakes at DONE’s little sound,
Durable messages wait safe and sound.
🐇 Relay trails bloom bright underground.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: documenting plain-shell orchestration for orchestrating-agent-relay.
Description check ✅ Passed The description is directly related to the documented plain-shell orchestration changes and troubleshooting guidance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch orchestrating-plain-shell-sends

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/orchestrating-agent-relay/SKILL.md`:
- Around line 313-319: Update the documented `agent-relay node tail | grep -m1
'"body":"DONE'` wake-up pipeline to run in the background by appending the
appropriate shell background operator. Preserve its existing marker-matching
behavior and surrounding explanation.
- Around line 313-319: Update the backgrounded wake-up pipeline near the relay
tail example and its corresponding usage so it matches the expected from and
target fields and a run-specific marker in the relay_inbound event before
exiting. Define or reuse the run-specific marker consistently across the sender
and wake-up trigger, preserving the trigger’s role as a completion signal only
for the current run.
- Around line 283-284: Update the orchestrator token registration flow to fail
when the register/grep pipeline produces an empty TOKEN before writing any
credential. Ensure .agentworkforce/relay/orchestrator.token is explicitly set to
0600, including when it already exists, before saving or reusing the token.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 45969647-2d6a-4477-81a7-11f7af4b26e3

📥 Commits

Reviewing files that changed from the base of the PR and between 0f3fcf2 and 12a82cc.

📒 Files selected for processing (1)
  • skills/orchestrating-agent-relay/SKILL.md

Comment thread skills/orchestrating-agent-relay/SKILL.md
Comment thread skills/orchestrating-agent-relay/SKILL.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12a82cc673

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/orchestrating-agent-relay/SKILL.md
willwashburn and others added 2 commits July 22, 2026 09:03
…en capture

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… start

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant