Fix token error handling in named type parameters - #324
Merged
Conversation
parseColumnTypeWithNamedParams still uses tryConsumeTokenKind as a single-value function after the helper changed to return a token and an error. This prevents the merged trunk from compiling. Handle the error before checking whether a comma was consumed, matching the other callers. The existing named-type fixtures exercise parsing.
git-hulk
added this pull request to stack #325
September 10, 2026 09:34
git-hulk
marked this pull request as ready for review
September 10, 2026 09:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The named-type parameter parser still treats
tryConsumeTokenKindasreturning only a token. After the helper gained an error return, this
caller prevents trunk from compiling.
Reproduction
Fix
Handle the returned error before checking whether a comma was consumed.
This PR changes only that caller in
parseColumnTypeWithNamedParams.Test
The existing named-type fixtures cover successful parsing.
make test(including race and compatibility tests),
make lint, andmakepasswith Go 1.21.13. Tests/lint use external linking on macOS.