Reject undelimited SSE frames at EOF - #181
Merged
Merged
Conversation
AetherAI3
force-pushed
the
fix/sse-eof-terminal
branch
from
September 27, 2026 20:54
4822f37 to
dfb144e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SSE decoder previously parsed the last buffered
data:line at EOF even when the server never sent the blank-line event delimiter. An undelimiteddoneframe could therefore mark an interrupted chat turn as successful.Require the delimiter before dispatching a frame. An unfinished
data:line now raisesStreamIncompleteError, preserving the turn's uncertain result and allowing dev-session consumers to reconnect. Trailing comments remain harmless.Verification
npm run buildnode --test --test-isolation=none dist/test/stream.test.js dist/test/turn_lifecycle.test.js dist/test/brain_cloud_dev.test.js dist/test/client.test.js(58 passed)git diff --check