Repository navigation
Fix component cancellation cleanup on macOS - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling a component operation stopped the worker group in the signal handler and again in the finalizer. On the macOS release runner, the second cleanup returned EPERM after the group had exited, turning a successful cancellation into an error and blocking the v0.9.0 release build.
Cleanup now runs once in the finalizer. Group permission errors are tolerated only after the leader has exited; a live leader still fails closed. Both graceful and forced cleanup retain descendant termination.
Validation: all 35 web-audio tests passed locally, including the live/dead leader permission cases. The real supervisor/worker/grandchild cancellation test passed five consecutive times. The successful preflight, subsequent tag-run failure and exact release state are recorded in the change's release-verification.md.
The owner authorized recreating the unpublished v0.9.0 tag after validation, retaining version 0.9.0. Release Pin run 34218397887 rebuilt both components; its full manifests were downloaded and the changed web-audio pin committed. The complete release preflight 34219264655 passed on 211d189: both builds and the comparison of all three ZIPs succeeded. Hosted validation passed 814 backend tests (11 skipped), 145 UI tests and all 35 web-audio tests. CI, all CodeQL language checks and Release Pin are green. The tag will be recreated on the squash merge with an exact remote lease. No release or asset was published by the failed attempt.