Skip to content

Fix nullable schema generation for union types #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdrianStrugala merged 5 commits into from
Apr 23, 2026
Merged

Fix nullable schema generation for union types #178

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fc8773
Implement nullable type handling in union schemas
robertcoltheart Mar 6, 2026
0ccd023
fix enum parsing for unions
robertcoltheart Mar 7, 2026
43d0eab
fix test
robertcoltheart Mar 7, 2026
a1b1827
Revert "fix test"
robertcoltheart Mar 7, 2026
3652554
Revert "fix enum parsing for unions"
robertcoltheart Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/AvroConvert/AvroObjectServices/BuildSchema/ReflectionSchemaBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,9 +440,17 @@ private TypeSchema TryBuildUnionSchema(Type memberType, MemberInfo memberInfo, D
{
result.Add(memberType);
}

var unionSchemas = result.Select(type => CreateNotNullableSchema(type, schemas, currentDepth + 1, memberInfo, representation)).ToList();

var typeInfo = _resolver.ResolveType(memberType, memberInfo);

return new UnionSchema(result.Select(type => CreateNotNullableSchema(type, schemas, currentDepth + 1, memberInfo, representation)).ToList(), memberType);
if (typeInfo.Nullable)
{
unionSchemas.Insert(0, new NullSchema());
}

return new UnionSchema(unionSchemas, memberType);
}

private FixedSchema TryBuildFixedSchema(Type memberType, MemberInfo memberInfo, NamedSchema parentSchema)
Expand Down
Loading