Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The previous commuter rule considered YouBike available whenever a station had a single bike, regardless of trip distance or whether the departure would nearly empty the station. Visitor selection had the same distance gap and only checked that enough bikes existed for the group.
These stricter rules prevent the simulation from presenting YouBike as a reliable option for long trips or stations with fragile inventory.
Validation
python3 -m unittest tests.test_ubike tests.test_commuter tests.test_visitor -q— 32 tests passed.git diff --check— passed.python3 -m compileall -q simulation tests— passed.The full test discovery still requires the repository's optional FastAPI dependency and two external data fixtures that are not present in the checkout.