Repository navigation
Add bounded TCP payload evidence for PCAP analysis - #185
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tcp_payload_evidenceWhy
NetWatch now reports TCP conversation completeness, but the existing flow history does not itself encode payload events. PCAP imports already extract exact TCP segment lengths without retaining payload content. This change exposes that evidence directly and safely so analysts can distinguish control-only conversations from data-bearing traffic without storing application payloads.
Research basis
Wireshark TCP completeness explicitly separates DATA evidence from SYN/SYN-ACK/ACK/FIN/RST evidence. Zeek connection metadata likewise exposes directional byte counts while retaining connection-level history. NetWatch keeps its own representation and conservative privacy boundary rather than copying either product.
Safety
Metadata-only; no payload bytes are retained, reconstructed, searched, replayed, or exported by this feature. Processing is bounded to 10,000 records per summary.