Repository navigation
ruff_cpp_spo: harvest_pgring example (structure-only harvest of PG-Ring) - #126
Conversation
… input for D-ASM-11) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abe5d61c0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
CI diagnosis for PR #126 (Rust baseline 1.99 throughout, unchanged):
The new CI run is processing. For the publish gate, the sound follow-up is to align internal released crate versions and semver requirements (and prove the packaged tarball resolves only one mutually compatible ABI set). I deliberately did not replace verification with |
|
Follow-up fix for the remaining Commit The |
… harvester's attribution CppFunction gains file, the definition's own location. The walker reports an inline header function in every translation unit that includes it, and a text search for its name finds declarations and calls first, so the harvester attributed functions to the wrong files. harvest_pgring now: - attributes functions by that location; - names an out-of-line method once (Class::method, not Class::Class::method) and prints the callee spelling so definitions join their call edges; - takes a class from a translation unit with parse errors only when no clean unit declares it, and lists the classes taken that way; - states that methods defined inside a class body are signatures only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Adds
crates/ruff_cpp_spo/examples/harvest_pgring.rsand its[[example]]entry (requires thelibclangfeature).The example walks the PG-Ring sources (Gómez-Brandón, Hogan, Navarro, ISWC 2026, arXiv 2608.03840) and writes:
manifest.ndjson;PG-Ring is GPL-3.0. The example reads its source only to extract that structure; no code is copied, and the corpus is not vendored. The output feeds the clean-room idea catalogue in lance-graph astral-sh#1600.
Run it with
PGRING_SRC,SDSL_INCLUDEandLIBCLANG_PATHset, as shown in the example's header.Generated by Claude Code