Repository navigation
Bump rust-version floors to 1.98.1 - #119
Conversation
Workspace-wide sweep to 1.98.1 (rust-toolchain, rust-version, Dockerfile base images, CI MSRV pins). Docker tags rust:1.98.1, -bookworm and -slim-bookworm verified to exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (9)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe workspace and eight package manifests now declare Rust 1.98.1 as the minimum supported version. ChangesRust version requirements
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The minimum is now Rust 1.98.1, and the supported build paths remain aligned with that toolchain. No merge-blocking impact is indicated. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit checks the Rust-version line, Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_1d9feb2c-877a-44ed-945e-1a965e4c4719) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f970074e75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Please update rustfmt.toml when bumping the Rust edition | ||
| edition = "2024" | ||
| rust-version = "1.95" | ||
| rust-version = "1.98.1" |
There was a problem hiding this comment.
Keep the workspace MSRV two releases behind stable
1. With rust-toolchain.toml already selecting Rust 1.98.1, this sets the workspace MSRV to the latest compiler instead of the N-2 floor promised by docs/versioning.md:69-72 and required by the upgrade procedure in CONTRIBUTING.md:581-585. The value propagates to all 60 workspace packages, so source builders using Rust 1.96 or 1.97 are now rejected before compilation and the MSRV CI job merely retests the development toolchain; keep this floor at no newer than 1.96.
AGENTS.md reference: AGENTS.md:L86-L88
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Not changing this. Raising the floor to 1.98.1 is an explicit fork-wide decision: every AdaWorldAPI repo in this sweep moved its toolchain and rust-version to exactly 1.98.1 together. That deliberately departs from the upstream N-2 policy in docs/versioning.md for this fork. If the fork should keep the N-2 floor instead, the maintainer can restore 1.96 here. The toolchain pin can stay at 1.98.1 either way.
Generated by Claude Code
This PR is part of the workspace-wide move to Rust 1.98.1. It raises the root
rust-versionfrom 1.95 to 1.98.1, and does the same in the 8 member crates that pin their ownrust-version.🤖 Generated with Claude Code
https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
Generated by Claude Code
Summary by CodeRabbit