Skip to content

Bump rust-version floors to 1.98.1 - #119

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/llvm-codegen-polyfill-gni3cw
Sep 25, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
claude/llvm-codegen-polyfill-gni3cw

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

This PR is part of the workspace-wide move to Rust 1.98.1. It raises the root rust-version from 1.95 to 1.98.1, and does the same in the 8 member crates that pin their own rust-version.

🤖 Generated with Claude Code

https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm


Generated by Claude Code

Summary by CodeRabbit

  • Compatibility
    • The minimum supported Rust version is now 1.98.1. Use Rust 1.98.1 or later to build the project. This requirement applies across the workspace and its packages, including packages that previously supported older Rust versions.

Workspace-wide sweep to 1.98.1 (rust-toolchain, rust-version, Dockerfile
base images, CI MSRV pins). Docker tags rust:1.98.1, -bookworm and
-slim-bookworm verified to exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 90a805e2-79eb-423b-a752-7592c0b08377

📥 Commits

Reviewing files that changed from the base of the PR and between d8ec10e and f970074.

📒 Files selected for processing (9)
  • Cargo.toml
  • crates/ruff_cpp_codegen/Cargo.toml
  • crates/ruff_cpp_spo/Cargo.toml
  • crates/ruff_csharp_spo/Cargo.toml
  • crates/ruff_python_dto_check/Cargo.toml
  • crates/ruff_r2il/Cargo.toml
  • crates/ruff_ruby_spo/Cargo.toml
  • crates/ruff_spo_address/Cargo.toml
  • crates/ruff_spo_triplet/Cargo.toml

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


📝 Walkthrough

Walkthrough

The workspace and eight package manifests now declare Rust 1.98.1 as the minimum supported version.

Changes

Rust version requirements

Layer / File(s) Summary
Update Rust version requirements
Cargo.toml, crates/ruff_cpp_codegen/Cargo.toml, crates/ruff_cpp_spo/Cargo.toml, crates/ruff_csharp_spo/Cargo.toml, crates/ruff_python_dto_check/Cargo.toml, crates/ruff_r2il/Cargo.toml, crates/ruff_ruby_spo/Cargo.toml, crates/ruff_spo_address/Cargo.toml, crates/ruff_spo_triplet/Cargo.toml
The workspace and eight package manifests set their declared minimum Rust version to 1.98.1.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to f9700

The minimum is now Rust 1.98.1, and the supported build paths remain aligned with that toolchain. No merge-blocking impact is indicated.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: raising the Rust version floors to 1.98.1 across the workspace and member crates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

A rabbit checks the Rust-version line,
The manifests now match at 1.98.1.
Nine small edits, all neat and clear,
The bunny hops with specs in gear.
Then nibbles clover, pleased to be done.

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 25, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_1d9feb2c-877a-44ed-945e-1a965e4c4719)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 25, 2026 02:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f970074e75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml
# Please update rustfmt.toml when bumping the Rust edition
edition = "2024"
rust-version = "1.95"
rust-version = "1.98.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the workspace MSRV two releases behind stable

1. With rust-toolchain.toml already selecting Rust 1.98.1, this sets the workspace MSRV to the latest compiler instead of the N-2 floor promised by docs/versioning.md:69-72 and required by the upgrade procedure in CONTRIBUTING.md:581-585. The value propagates to all 60 workspace packages, so source builders using Rust 1.96 or 1.97 are now rejected before compilation and the MSRV CI job merely retests the development toolchain; keep this floor at no newer than 1.96.

AGENTS.md reference: AGENTS.md:L86-L88

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changing this. Raising the floor to 1.98.1 is an explicit fork-wide decision: every AdaWorldAPI repo in this sweep moved its toolchain and rust-version to exactly 1.98.1 together. That deliberately departs from the upstream N-2 policy in docs/versioning.md for this fork. If the fork should keep the N-2 floor instead, the maintainer can restore 1.96 here. The toolchain pin can stay at 1.98.1 either way.


Generated by Claude Code

@AdaWorldAPI
AdaWorldAPI merged commit c800974 into main Sep 25, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants