[AdaWorldAPI]

Why

ruff pins 1.97.1; this repo pinned 1.93.0. That split was already fictional in one direction: ruff_r2il (the R2IL intake arm, ruff#94) lives inside the ruff tree, so rustup's directory walk gives it ruff's 1.97.1 — and it path-deps r2il / r2ssa. This repo's source was therefore already being compiled under 1.97.1 whenever the intake arm built; the pin just didn't say so. 1.93.0 applied only when building from inside this directory.

Aligning the pin makes cargo fmt produce identical output on both sides of that seam, which is the point.

Measured before changing anything

• cargo fmt --all --check is clean under BOTH 1.93.0 and 1.97.1 — so the bump costs zero reformatting churn. This was the actual open question (rustfmt output does differ across these versions in general); here it does not.
• cargo clippy --workspace --all-features -- -D warnings under 1.97.1 was not clean: 9 lints across 4 crates, revealed one crate at a time because cargo stops at the first failure — r2ssa (4) → r2sym (2) → r2dec (2) → r2plugin (1).

The fixes

All behavior-identical, all hand-applied. No cargo clippy --fix.

Crate	File	Lint	Change
r2ssa	function.rs	while_let_loop	loop { let Some(x) = .. else { break }; } → while let Some(x) = .. { }
r2ssa	phi.rs	unnecessary_sort_by	sort_unstable_by(...cmp...) → sort_unstable_by_key(|(a,_)| *a)
r2ssa	semantic.rs	question_mark	else if let .. else { return None } chain → strip_prefix("ram:")?
r2sym	value.rs	manual_checked_ops	explicit if *b == 0 guard around *a / *b → a.checked_div(*b)
r2ssa, r2sym, r2dec ×2, r2plugin	—	collapsible_match ×5	Pat => { if C { BODY } } → Pat if C => { BODY }

Two correctness notes, because both classes can silently change behavior

checked_div is only equivalent on unsigned. The value field is u64, so checked_div returns None exactly when the divisor is zero — matching the guard it replaces. On a signed type it would also return None for MIN / -1, which would be a real behavior change. Type checked first.

collapsible_match moves non-matching cases to a later arm. Each of the five was verified individually before collapsing, never on clippy's word:

• Four had no else at all, with _ => {} as the fallthrough — a no-op either way.
• The fifth (r2sym/value.rs, the concat path) had an else body byte-identical to the _ arm's body.

Verified after

• cargo clippy --workspace --all-features -- -D warnings → 0 errors
• cargo fmt --all -- --check → clean
• 541 tests green across the changed non-z3 crates (r2ssa 371+59+99, r2dec, r2il), 0 failures
• Downstream ruff_r2il still passes 43/43 against these crates

Known, pre-existing, not caused by this

r2sym and r2sleigh-plugin cannot link in a container without Z3 — rust-lld: error: unable to find library -lz3. Confirmed identical under the old 1.93.0 toolchain, so it is a missing system library, not a consequence of this bump. CI installs Z3, so CI is unaffected.

---

Generated by Claude Code

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_c3462c25-cb35-4810-93e4-d992be60165e)

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.