Skip to content

feat(lance-fold): validate one-hop traversal against petgraph BFS - #2

Merged
AdaWorldAPI merged 6 commits into
masterfrom
experiment/lance-fold-hop-20261019
Oct 19, 2026
Merged

AdaWorldAPI merged 6 commits into
masterfrom
experiment/lance-fold-hop-20261019

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Fork-first executable slice

This PR adds a standalone, feature-gated experiment inside the petgraph fork (not a GraphFoldView adapter). It directly executes lance-graph-mask-risc over borrowed source/target SoA columns and snapshot masks: edge-presence-gated Gather(source, frontier) → visibility-gated Gather(target, visible) → ScatterOrU32(target) into the demanded one-hop node mask. Petgraph's own Bfs supplies the independent oracle only in tests.

Tests

Six tests pin BFS first-layer parity (>64-row boundaries, duplicates), private bridge isolation, same-row-order/different witness presence, stale/unauthorized seeds, deleted edges, and mask/id validation. Source dependency pinned to a specific lance-graph commit.

Build isolation

Own [workspace] under experiments/lance-fold-hop. No changes to petgraph/petgraph-core APIs or default workspace dependency graph. An opt-in GitHub Actions workflow runs cargo test --manifest-path experiments/lance-fold-hop/Cargo.toml --features lance.

Architecture/known gap

ScatterOrU32 is a demanded sink under lance-graph's no-intermediate-population rule. This PR claims only one hop; it does not misrepresent this as a Gremlin repeat() implementation. Once the probe passes, implement an upstream fold/continuation primitive in lance-graph for iterative frontier scheduling, then make this fork consume that primitive. lance-graph-core extraction follows evidence from multiple consumers, not this PR.

Validation

  • GitHub Actions compile/tests (no local Rust toolchain or network available in authoring runtime)
  • Verify pinned git dependencies resolve cleanly in an external consumer context
  • Confirm no new materialized graph and correct visibility semantics.

@AdaWorldAPI AdaWorldAPI changed the title experiment: run a petgraph BFS hop through lance-graph Mask-RISC feat(lance-fold): validate one-hop traversal against petgraph BFS Oct 19, 2026
@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 19, 2026 15:22
@AdaWorldAPI
AdaWorldAPI merged commit 1e0ba99 into master Oct 19, 2026
15 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T15:23:26.757571Z e4e6abb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant