Repository navigation
feat(lance-fold): validate one-hop traversal against petgraph BFS - #2
Merged
Merged
Conversation
AdaWorldAPI
marked this pull request as ready for review
October 19, 2026 15:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-first executable slice
This PR adds a standalone, feature-gated experiment inside the petgraph fork (not a
GraphFoldViewadapter). It directly executeslance-graph-mask-riscover borrowed source/target SoA columns and snapshot masks: edge-presence-gatedGather(source, frontier)→ visibility-gatedGather(target, visible)→ScatterOrU32(target)into the demanded one-hop node mask. Petgraph's ownBfssupplies the independent oracle only in tests.Tests
Six tests pin BFS first-layer parity (>64-row boundaries, duplicates), private bridge isolation, same-row-order/different witness presence, stale/unauthorized seeds, deleted edges, and mask/id validation. Source dependency pinned to a specific lance-graph commit.
Build isolation
Own
[workspace]underexperiments/lance-fold-hop. No changes to petgraph/petgraph-core APIs or default workspace dependency graph. An opt-in GitHub Actions workflow runscargo test --manifest-path experiments/lance-fold-hop/Cargo.toml --features lance.Architecture/known gap
ScatterOrU32is a demanded sink under lance-graph's no-intermediate-population rule. This PR claims only one hop; it does not misrepresent this as a Gremlinrepeat()implementation. Once the probe passes, implement an upstream fold/continuation primitive in lance-graph for iterative frontier scheduling, then make this fork consume that primitive.lance-graph-coreextraction follows evidence from multiple consumers, not this PR.Validation