Repository navigation
D-GLOBAL-WHERE P0: direct-routed virtual SoA views across selections + DuckDB parity gate (lab) - #1943
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65c89b3264
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d18651f to
771ec92
Compare
Spec for the cross-selection routing falsifier and the DuckDB parity gate. No production change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Cross-selection routing through existing dt64 MapTable/LocalMap, Quack WHERE, ndarray mask folds. Lab only; no production change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Falsifier 21/21 (F4, F6 disable-verified). DuckDB 2.0.0 gate: 336/336 answers agree; warm best arm 12/0/0 per workload but dominated by DuckDB's fixed per-query cost except the multi-hop rows; cold multi-tile losses from per-id MapTable::locate. W8 label fixed (after-delete answer is W8_after). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
771ec92 to
26f31b6
Compare
Lab only. No production change. dt64, Quack, mask-risc and ndarray are used unchanged. No Gather, no new identity table, no witness store, no per-object allocation. The full write-up is in
.claude/probes/2026-11-03-d-global-where/REPORT.md.Falsifier: 21/21 (
probe/→falsify)Two guards were disabled to prove they are load-bearing; both checks then went red:
What the checks establish:
LocalMap,MapTable::{map, map_at, locate},Frame) is exact and bidirectional. It reconciles two selections that hold the same global id at different local positions.where_dr3::LocalSelectionprojects bit-identically for two methods. ItsSchemaChangedon a second method is therefore a coupling, not a correctness need. Scope refuses on its own.DuckDB 2.0.0 parity gate (benchmark gate preserved here)
Setup:
Answers: 336/336 agree (
duckdb/compare.pyexits 1 on any mismatch).Warm, best arm: 12/0/0 W/P/L for every workload. This does not establish general superiority.
multi_densemulti_skewedresults/explain/)multi_densemulti_denseLosses (all recorded): every loss is caused by addressing; none is caused by the fold.
multi_*dataset: 8.7–520 ms ours against 1.9–35 ms DuckDB. DuckDB's load (40–117 ms) is excluded from its cold figure.MapTable::locate, which reads every listed tile per id.multi_densetake 4.8 ms. That beats DuckDB's DELETE but is over the workspace's 1 ms gate.Plan choice is by measured cost:
csrwins everywhere.csrwins on small or sparse data; selection-first frontier masks win on medium, dense and skewed data.Remaining parity gap: scale ≥ 10M rows is unmeasured on our side.
Verdict
locate's ambiguity scan?Cube.Cube::new_tiled.Files (all under
.claude/probes/2026-11-03-d-global-where/)SPEC.md,REPORT.mdprobe/: its own workspace, binariesfalsifyandbenchduckdb/:bench_duckdb.py,compare.pyresults/: logs, JSON, compare tables, EXPLAIN ANALYZE output.claude/board/entries/2026-11-03-d-global-where-p0.md, with the index regenerated.Not included: benchmark commit
a84464205(D-DR-FOLD), #1941 and #1942. No merge requested.Generated by Claude Code