Repository navigation
test(drf-w4/w6): isolate the resampling refusal to changed bytes - #1771
Conversation
Codex P2 on #1767 (merged): the W6 resampling arm mutated the staged facet byte, which dirty_cycle overwrites, so regenerated payloads were identical; the HashConflict came from the reconciled head moving the frame base 0 -> 1 (the batch hash covers base_version). W4's 'source changes' had the same blind spot. Both now flip a byte no write stages and assert the regenerated rows really differ. W6 frames every arm on base 0 and adds a control: regenerating from the unchanged source reconciles, so only the changed bytes can cause the refusal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This fixes the Codex P2 finding on #1767, which merged before the review finished. The change is test-only.
What was wrong. The W6 "regenerate from the changed source" arm passed without testing what it claimed.
dirty_cycleoverwrites for every dirty row, so the regenerated payloads were identical.HashConflictcame from a different cause: the reconciled head moved the frame base from 0 to 1, and the batch hash coversbase_version.Fix
Checks. 23 tests pass with
--features handoff; clippy-D warningsis clean. With the source change removed, both tests fail at the new "rows differ" assertions, so the fixtures now discriminate.Board:
.claude/board/entries/2026-10-25-drf-w4-handoff.mdis updated.Generated by Claude Code