Skip to content

test(drf-w4/w6): isolate the resampling refusal to changed bytes - #1771

Merged
AdaWorldAPI merged 2 commits into
mainfrom
lab/drf-w6-resample-isolate-20261025
Oct 25, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
lab/drf-w6-resample-isolate-20261025

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

This fixes the Codex P2 finding on #1767, which merged before the review finished. The change is test-only.

What was wrong. The W6 "regenerate from the changed source" arm passed without testing what it claimed.

  • The source change flipped the staged facet byte, which dirty_cycle overwrites for every dirty row, so the regenerated payloads were identical.
  • The HashConflict came from a different cause: the reconciled head moved the frame base from 0 to 1, and the batch hash covers base_version.
  • W4's "the source changes while the WAL holds the commit" step had the same blind spot.

Fix

  • Both tests now flip byte 200, which no write stages, and assert that regenerating from the changed source really gives different rows.
  • W6 frames every arm on base 0, the cycle's own base.
  • W6 adds a control: regenerating from the unchanged source reconciles. So the changed bytes are now the only thing that can cause the refusal.

Checks. 23 tests pass with --features handoff; clippy -D warnings is clean. With the source change removed, both tests fail at the new "rows differ" assertions, so the fixtures now discriminate.

Board: .claude/board/entries/2026-10-25-drf-w4-handoff.md is updated.


Generated by Claude Code

Codex P2 on #1767 (merged): the W6 resampling arm mutated the staged facet
byte, which dirty_cycle overwrites, so regenerated payloads were identical;
the HashConflict came from the reconciled head moving the frame base 0 -> 1
(the batch hash covers base_version). W4's 'source changes' had the same
blind spot. Both now flip a byte no write stages and assert the
regenerated rows really differ. W6 frames every arm on base 0 and adds a
control: regenerating from the unchanged source reconciles, so only the
changed bytes can cause the refusal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0d288fa0-c932-42a9-a485-0e4c54a1254f
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 25, 2026 07:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T07:33:04.370768Z 7125af3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 332b420 into main Oct 25, 2026
12 checks passed
AdaWorldAPI added a commit that referenced this pull request Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants