Skip to content

lab(drf-g): key a focus on its facet too - #1769

Merged
AdaWorldAPI merged 3 commits into
mainfrom
lab/drf-focuskey-facet-20261025
Oct 25, 2026
Merged

lab(drf-g): key a focus on its facet too#1769
AdaWorldAPI merged 3 commits into
mainfrom
lab/drf-focuskey-facet-20261025

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Oct 25, 2026

Copy link
Copy Markdown
Owner

This fixes a cache-key bug in drf-focus-probe that I found while reading the focus manager for W8.

Bug. FocusKey was (source, map, scope), but a focus caches one gathered facet column. Loading the same map a second time with a different facet returned the first facet's column: the test measured 36595 where the second facet holds -5.

Fix. facet is now a FocusKey field, and Facet derives Hash. Two facets of one map build two foci; loading the same facet again is still a cache hit.

Tests. 24 pass (--features handoff) on native and on x86-64-v3; clippy -D warnings is clean and the examples build.

  • g_two_facets_of_one_map_are_two_foci_not_one_cached_column was committed first and failed on main.
  • Its silence twin asserts that the same facet is still served from the cache.
  • Disable run (load keys every focus on a constant facet): the new test and l2_retire_* go red.

Not affected: the W1–W7 writeback and handoff results, because writeback stages by an explicit facet and never reads the cached column. The p2_breakeven timings are unaffected too, since each run loads one facet per key.

Board: .claude/board/entries/2026-10-25-drf-focuskey-facet.md.

Generated by Claude Code

claude added 3 commits October 25, 2026 00:53
@claude
test(drf-g): two facets of one map are two foci
bcaade6 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@claude
lab(drf-g): key a focus on its facet too
285ca0c 
FocusKey was (source, map, scope), but a focus caches ONE gathered facet
column, so loading the same map with a second facet returned the first
facet's column (measured: 36595 where -5 was gathered). The facet is now
part of the key; two facets of one map are two foci.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@claude
board: D-DRF-G-FACET focus key fix
e6f127c 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 462305bc-f197-4007-ad81-da566b27e819
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI AdaWorldAPI mentioned this pull request Oct 25, 2026
Merged
@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 25, 2026 07:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T07:32:01.658023Z e6f127c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 94d254a into main Oct 25, 2026
12 checks passed
@AdaWorldAPI AdaWorldAPI mentioned this pull request Oct 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdaWorldAPI @claude