Skip to content

lab(drf-w3): same-facet writes apply by declared stream position - #1766

Merged
AdaWorldAPI merged 4 commits into
mainfrom
lab/drf-w3-ordered-apply-20261025
Oct 25, 2026
Merged

AdaWorldAPI merged 4 commits into
mainfrom
lab/drf-w3-ordered-apply-20261025

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

This adds the W3 ordered-apply arm of .claude/plans/d-dr64-focus-cache-falsifiers-v1.md §4 to drf-focus-probe.

Change

  • New Writeback::stage_at(slot, facet, value, pos). stage is unchanged and stages a write with no position.
  • flush sorts patches by (ord, offset, pos) and applies them in that order, so each facet ends with its highest-position value whatever order the writes were staged in.
  • Two different values for one facet are accepted only when they carry two distinct positions. At equal positions, or when one write has no position, they refuse with Conflict. Equal values coalesce.

Tests (17 pass on native and on x86-64-v3; clippy -D warnings clean)

  • Three overwrites through three aliasing slots give the right value in all 6 staging orders.
  • 64 writes over 4 rows in a scrambled staging order match a scalar oracle (highest position wins per row).
  • Equal-position and position-less conflicts refuse; their equal-value twins coalesce.

Disable runs (each turns its own test red)

  • Sort without pos, so staging order decides.
  • Treat equal positions as ordered.
  • Treat a write with no position as ordered.

Open: positions are caller-declared u64 values. Nothing ties them to a real stream (CycleWriter sequence, WAL LSN) yet; that is W4–W6.

Board: .claude/board/entries/2026-10-25-drf-w3-ordered-apply.md.


Generated by Claude Code

stage_at carries a position; flush sorts by (ord, offset, pos) and applies
in that order, so the highest position wins whatever the staging order.
Different values at one position, or next to an unordered write, refuse.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9ad3372e-547e-46c6-81a7-289f9dcb1ac8
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Both headings parsed as D-DRF, which entries_index --check rejects as a
duplicate id.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 25, 2026 00:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T00:36:04.010993Z 960cb72 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit e6d1578 into main Oct 25, 2026
12 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 960cb72c98

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/drf-focus-probe/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants