Repository navigation
lab(drmc): certificate keeps egglog's ProofStore + ProofId, not its rendering; L1 board records - #1742
Conversation
…d, not its rendering
RecipeCertificate held the proof as egglog's pretty-printed string.
It now holds EggProof { store: ProofStore, root: ProofId }, egglog's own
hash-consed proof arena, with render() for display only and node_count()
over the justification DAG. RecipeCertificate drops PartialEq/Eq
(ProofStore has no equality).
Comments: egglog's proof check is its own crate-private check_proof,
not an independent one; prove_equation's _law gates the call but the
rewrites are fixed in HEADER.
New test the_proof_object_grows_with_the_reassociation. report_costs
now prints the certificate without proof (272 B) and the proof as
8 nodes; the earlier 1 284 B counted the 1 012 B rendering.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
…orrection Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ents recipe.rs and tests/contract_handoff.rs said no certified-compiler boundary exists for DR64 laws. The single-operand admit_recipe path still has no certifier, but relcomp::certify_reassociation (#1707) certifies one law: associativity of Boolean-Distinct composition over a DR64 chain. #1738 corrected two other sites; these two remained. Comments only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Line-number citations into moving files replaced by symbol / entry-heading anchors; the stale-wording housekeeping row is marked DONE (#1742 + this PR). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Board conflicts resolved, keeping both sides: - STATUS_BOARD: the D-DRMC section from #1742 and the D-ONNX section. - PR_ARC_INVENTORY: #1742's entries for #1740 and #1741 replace this branch's catch-up versions; the #1726-#1739 catch-up stays. - LATEST_STATE: this branch's "main after #1741" text, which now has per-PR records for #1726-#1739. entries/README.md regenerated with entries_index.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
This PR closes L1 (#1740) with the smallest change. It touches only the lab crate and the board. Nothing in it is production.
Code (
crates/dr-math-binding-probe)RecipeCertificateused to store the proof as egglog's pretty-printed string. It now storesrelcomp::EggProof { store: egglog::proof::ProofStore, root: ProofId }, which is egglog's own proof arena.EggProofexposesrender()for display only, andnode_count(), which counts distinct nodes reachable through the justifications. It is never reduced to a string or a hash.RecipeCertificateno longer derivesPartialEqorEq, becauseProofStorehas no equality.prove_equationandprove_reassociationnow returnEggProof.check_proof, which is not an independent check._lawgates the call, but the rewrites are fixed inHEADER.egglog-r2il-probe/src/lib.rs, a comment-only change.the_proof_object_grows_with_the_reassociation. A full left-deep to right-deep proof must have more nodes than the trivial equation, and its root must relate two different terms.node_countchanged to return 1, the test went red. After restoring the code it is green.Measured (
report_costs,--release; reported, not gated)Board
PR_ARC_INVENTORYentries for dr-math-binding-probe: L1, reuse a D-DRMC-5 certificate on a fresh frame (X8) #1740 and board: coresearch map — Julia e-graphs vs egglog/datafrog/Ascent; Lisp vs Prolog for MeTTa #1741.STATUS_BOARDwith the rowsEXP-DRMC-L1(MEASURED) andEXP-DRMC-L2(held behind the ProofRef agreement on EXO-50).LATEST_STATEline.Gates run
cargo fmtcargo clippy --release --all-targets -- -D warningscargo test --release: all suites green, including the new test.Not done
Generated by Claude Code