Skip to content

test(dr-math): ClassView→DR→math offer→ACT-R handoff and isolated CI [4/5] - #1704

Merged
AdaWorldAPI merged 3 commits into
lab/dr-math-3-law-recipe-20261022from
lab/dr-math-4-handoff-gates-20261022
Oct 22, 2026
Merged

AdaWorldAPI merged 3 commits into
lab/dr-math-3-law-recipe-20261022from
lab/dr-math-4-handoff-gates-20261022

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Stage 4 / D-DRMC final stacked draft

Two cross-layer tests link real ClassView::compute_dag declarations to Stage 1 typed DR64 binding, Stage 2 finite-reference evidence, Stage 3 separate (synthetic) proof/compiled-recipe references and existing lance-graph-act-r deterministic proposal arbitration. Stale ACT-R decisions and attempts to treat a pure math offer as effect authorization are refused.

Adds isolated Cargo fmt/clippy/test workflow for the probe (not tested by root workspace), plus a factual G0–G9 acceptance matrix mapping MeTTa/MORK/datafrog oracle, Ruler/Enumo/egglog, effect-aware extraction, RelAlg, R2IL/Quack/mask-risc, Thought-Git and cognitive orchestration to distinct owners and falsifiers.

Not completed: real ClassView method registry adapter, sealed source attestations, real egglog/effect-safe compilation, independent theorem checker, R2IL integration, statistical or causal discovery, measured amortization. The synthetic proof flag is not proof. No production execution path, no storage, no action commit, no cognitive-shader-driver edits. Draft pending separate CI and owners' review. Base #1703, root #1700.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c0788df7-c10f-48ea-8aa5-a34a8b098eaf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 22, 2026 14:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T14:59:36.041186Z 63d27f3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

AdaWorldAPI pushed a commit that referenced this pull request Oct 22, 2026
Premise gate split the question into frame identity, finite-population
evidence, promotion and rebinding. Five scouts, a 21-row crosswalk and
three co-architect passes. Measured on the PR heads: 12/12 and 20/20 tests
pass, clippy clean, 17 and 32 rustfmt diffs, new probe workflow red at
Format. ADOPT-NOW candidates: the Unknown-before-Counterexamples ordering
defect, tautological fixtures, caller-set proof disposition, frame/focus/
scope split, validity as a carrier of R, CI fix. Nothing adopted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
The merge carries stage 3's Stage B proof identity, and in the same
commit the stage 4 files that had to change with it (the handoff test
does not compile against the new API otherwise).

Conflict in Cargo.toml: keep both the egglog-r2il-probe dependency and
the lance-graph-act-r dev-dependency.

Coresearch D-DRMC items X17 and X20 (operator-chosen), plus the cheap
X19 tightening:
- contract_handoff bound Gamma and R to the same array, so "Gamma subset
  of R" could not fail. R now holds the selected pair and one more; the
  census is (1, 1, 0, 0). The proof is Stage B's re-checked E1 capsule,
  the target Stage B's TargetAbi.
- The ACT-R snapshot version is read from the bound frame instead of a
  literal that matched the source revision by coincidence.
- The effect refusal asserts EffectRequiresSeparateAuthorization, not
  any error.
- The workflow was red at Format and installed `stable` while the repo
  pins 1.99. It now mirrors egglog-r2il-probe.yml: rustup show on the
  pinned toolchain, the ndarray sibling checkout the new
  egglog-r2il-probe dependency needs, native rustflags, cache, release
  tests, and triggers on the crates the probe now depends on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg

Copy link
Copy Markdown
Owner Author

Pushed 1f63a5b1 here. It merges stage 3 and fixes this stage's files in the same commit; the handoff test would not compile against the new API otherwise. It applies coresearch items X17 and X20 plus the X19 tightening:

  • X17: contract_handoff no longer binds Gamma and R to the same array. R holds the selected pair and one more, giving a census of (1, 1, 0, 0). The proof is Stage B's re-checked E1 capsule.
  • X18 note: the ACT-R snapshot version is now read from the bound frame. Before, it was a literal that matched the source revision by coincidence.
  • X19: the effect refusal now asserts EffectRequiresSeparateAuthorization instead of accepting any error.
  • X20: the workflow was red at Format and installed stable while the repo pins 1.99. It now mirrors egglog-r2il-probe.yml: the pinned toolchain via rustup show, the ndarray sibling checkout (the new dependency needs it), native rustflags, cache and release tests. Its triggers now include the crates the probe depends on.

Locally on 1.99: all suites pass (8 + 2 + 7 + 6 + 1 doctest), and clippy -D warnings and fmt are clean.


Generated by Claude Code

Stage 3 no longer uses Stage B's ReplayCapsule as proof authority (see
ca88fea). Follow-through in this stage, in the merge because the
handoff test does not compile against the new API otherwise:

- Cargo.toml: egglog-r2il-probe dependency and patches dropped; the
  lance-graph-act-r dev-dependency stays.
- contract_handoff: the recipe admission ends in NoCertifiedCompiler;
  ACT-R arbitrates on census eligibility alone, never on a proof.
- Workflow: the pinned toolchain stays; the ndarray sibling checkout and
  the egglog/r2il/mask-risc triggers are gone with the dependency.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg

Copy link
Copy Markdown
Owner Author

Follow-up e7920adb merges the corrected X15 from #1703 (ca88feaf), which no longer uses ReplayCapsule as proof authority.

  • The handoff test now ends the recipe admission in NoCertifiedCompiler. ACT-R arbitrates on census eligibility alone, never on a proof.
  • The egglog-r2il-probe dependency is gone, and with it the ndarray sibling checkout and the extra triggers in the workflow.
  • The workflow still uses the pinned toolchain.

Locally: all tests pass (8 + 2 + 7 + 5 + 1 doctest), and clippy -D warnings and fmt are clean.


Generated by Claude Code

@AdaWorldAPI
AdaWorldAPI merged commit a4fc19f into lab/dr-math-3-law-recipe-20261022 Oct 22, 2026
11 checks passed
AdaWorldAPI added a commit that referenced this pull request Oct 22, 2026
chore(dr-math): land the stranded D-DRMC stack (#1701-#1704 + charter amendment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants