Repository navigation
dir-rmap-probe: rft1_cost — where the D-RFT-1 composition's time goes (measurement only) - #1688
Conversation
…ent only) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30f6418a8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
D-RFT-1 already names the d-rft-d-lfa-0 assessment; the duplicate failed entries_index.py --check in the supersession-index workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
This PR covers item D of the post-merge review of #1681 (
GPT:gpt-ada-01/20261021-pr1674-1682-consolidated-review-01). I did it on the operator's instruction (EXO-50/038). It is measurement only:compose.rs, r2il and mask-risc are unchanged.Files
crates/dir-rmap-probe/examples/rft1_cost.rs, the instrument (new).claude/board/entries/2026-10-21-d-rft-1-cost-breakdown.md, the findings (new), plus the regenerated entries indexFindings
Fixture:
Spec::small(), 600 users on 3 pages (Spec::iam(8000)exceeds 256 slots). Release build, 4 cores, load around 2 during the runs. The ranges below cover three runs.Composer::newtakes 0.8–1.4 µs; arm A takes 212–270 µs per passexecute_intocalls per passplane_count3count_and(3)54–70; presentkeep(intersect 2)48–62; supportkeep(union 4)101–129; fancount_and(1)95–121;plane_countcompile + scratch 319–400 ns per pagendarray::simd, i.e. about 52–67 ns of fixed overhead per callexecute_into; 18 per pass from compilingplane_countinsidecomposeReading. Fixed per-call overhead dominates arm A, not the mask work itself, so the lever is fewer invocation boundaries.
Not built. A batched multi-coordinate fold (a count product or a positional popcount) needs its own admission decision and falsifiers. It must also keep the Bag/Distinct, NULL, witness and refusal contracts.
The three comparisons (A, C, C+) keep the definitions from
rft1_bench.Open
count_and(1)over one plane costs more per call thancount_and(3)over three, in every run.Gates
Clippy
--examples -D warningsand fmt are clean. All results are in ns or µs; nothing is in milliseconds.I will not merge this PR; it waits for your review.
Generated by Claude Code