Repository navigation
board: correct the D-QSP-0 entry's G1 claim (NULL literals need no new carrier) - #1680
Conversation
…ew carrier The entry and EXO-50 /027-/028 said NULL literals and NOT IN (..., NULL) need a constant-UNKNOWN Filter leaf and a FALSE carrier. That was asserted without reading the substrate. A NULL operand is a lane alias with an all-clear presence plane under sql_where, and the existing API matches PostgreSQL 16.15 on the six measured predicates (EXO-50 /029). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…1680/#1682, boundaries Only this session's rows and entry: the STATUS_BOARD "D-QSP-0 remainder" row (In PR -> Shipped, slice 2 added), PR_ARC entries for #1675, #1680 and #1682 prepended, and the entry now states that Quack has no NULL-literal Filter variant, that the PostgreSQL examples are lab evidence and not CI, and #1682's final CI (18/18 green on 96e8010). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
Board-only correction to the entry merged in #1675.
What was wrong. The entry (and EXO-50
/027,/028) said NULL literals andNOT IN (…, NULL)(gap G1) need a constant-UNKNOWNFilterleaf and a FALSE carrier. That was asserted without reading the substrate.What the code does.
crates/lance-graph-quack/src/lib.rs:18).sql_where's leaf arm (lib.rs:580-591) rewrites a leaf on a nullable column toT = valid ∧ leaf,F = valid ∧ ¬leaf.Filter::Plane.On
x = {1, 2, NULL, 1}, the existing API returns0, 2, 2, 0, 0, 0forx NOT IN (1, NULL), its negation,x IN (1, NULL), its negation,x = NULLand its negation. PostgreSQL 16.15 returns the same (EXO-50/029).The G1 rows of
entries/2026-10-21-pg-classview-polyfill-map.mdwere written by another session and are not edited here. The correction names them.Still open: a committed test and a random PostgreSQL differential with NULL operands.
Generated by Claude Code