Repository navigation
D-RU-1 (U1): JC statistics batch over shared power-sum passes (lab probe) - #1643
Conversation
…P, pre-disable) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
…sured) 252 requests over 2 selections reduce to 2 selection and 42 cross passes. At 1M rows the batch is 6.4x faster than answering each request alone, with 11.5x fewer rows traversed, 8.5x fewer values read and 126x fewer mask bytes; answers are bit-identical. Six disable runs turn the tests red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c9ead98c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A Rel::Plane(i) selection was accepted and then failed inside the fold, because the probe passes no resident masks. Both paths now refuse it up front with BatchError::ResidentPlane; resident planes are U2's let-planes, and Cost does not count plane reads. Codex review on #1643. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
A Rel::Plane(i) selection was accepted and then failed inside the fold, because the probe passes no resident masks. Both paths now refuse it up front with BatchError::ResidentPlane; resident planes are U2's let-planes, and Cost does not count plane reads. Codex review on #1643. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
…entries index after #1643 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
jc-batch-probe: refuse selections that name a resident plane (Codex follow-up to #1643)
Lab probe
crates/jc-batch-probe; no production path. Plan:.claude/plans/d-relalg-unified-v1.md§3 (U1). Entry:.claude/board/entries/2026-10-20-u1-jc-batch.md.What it does
A batch of JC statistical requests is answered in two ways:
relalg::normalize.GroupCrossPowerSumsI32pass keyed by the group lane.GroupPowerSumsI32pass.checked_merge. Univariate answers read one side of the cross sums.Statistics covered: mean, variance, one-way ANOVA, covariance, Pearson, R², and the simple regression line in both directions. A request built for another version is refused by both paths.
Measured
Battery: 252 requests over 2 selections and 7
I32lanes. It reduces to 2 selection passes and 42 cross passes. The table gives medians of 5 warm runs.Costis counted from the programs that actually run, not from a model.Correctness
pearsonandanova_one_way, plus two-pass mean and variance.i32extremes,Σx²passesu64andΣxypassesi64(the test asserts both); mean and variance still equal the exacti128values.8 tests pass. Six disable runs each turned red, with every anchor asserted:
normalize;Not covered
MergeOverflow: untested; it cannot occur below the 2³²-row cap.Board and CI
Cargo.tomlexcludes the crate.jc-batch-probe.yml: clones the sibling ndarray, then runs fmt, clippy-D warnings, the tests and a benchmark smoke run.Generated by Claude Code