Repository navigation
D-RELALG-UNIFIED: assessment, decisions and stage order (docs only) - #1641
Merged
Merged
Conversation
Plan .claude/plans/d-relalg-unified-v1.md: can JC/R statistics and Datalog programs share one optimized algebra, executed through relalg / R2IL / mask-risc and Quack? Assessment: no shared relational expression graph exists. relalg is a single-table Boolean selection algebra with a terminal measure. Quack has no cost model and does not consume relalg. Each layer therefore gets the smallest extension instead of a new AST: - JC request batches share the power-sum terminals (U1, first); - let-bound planes on the contract set IR (U2, after D-CMR-1); - a co-addressed join over JoinDomain; - measured Quack pins instead of a cost model; - recursion over BIND tiles, gated on an attested slot assignment. Decisions recorded (operator, 2026-10-20): - ADMISSION = B: counted, version-witnessed same-table seeks are admitted in preparation; cross-table positional gathers stay forbidden; frozen codebook lookups are admitted under attestation; D-MPS-8 is not cleared automatically. - D-RA-2 = A: the set algebra and its rewrite rules belong in lance-graph-contract; relalg keeps lowering and relational planning. Three negatives rest on grep only and are marked not yet fully verified: no JC expression IR, no D-CMR set IR code, no D-MSUB. Board: STATUS_BOARD section D-RU-0..8 and the D-RA-2 status; ISS-ADMISSION-PREP-BINDING status; INTEGRATION_PLANS; entry 2026-10-20-d-relalg-unified; entries index. The supersession index regenerates unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves the ISSUES/STATUS_BOARD conflicts with #1640, which recorded the same ADMISSION B and D-RA-2 A rulings. Keeps #1640's wording, adds the frozen-codebook clause and the no-general-AST clause, and points the plan's Decisions section at entries/2026-10-20-six-decisions.md as the authority. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
AdaWorldAPI
marked this pull request as ready for review
October 20, 2026 23:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
AdaWorldAPI
pushed a commit
that referenced
this pull request
Oct 21, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation and board only; no code. Plan:
.claude/plans/d-relalg-unified-v1.md.Question
Can JC's R-compatible statistics and Datalog programs share one optimized algebra, so that redundant joins, sums and passes are found once, and then execute through relalg / R2IL / mask-risc and Quack?
Assessment
No shared relational expression graph exists today.
lance-graph-relalgis a single-table Boolean selection algebra with a terminal measure: sevenRelvariants, no joins, projection, grouping, variables, recursion or sharing.The plan therefore gives each layer the smallest extension, not a new AST:
GroupPowerSumsI32,GroupCrossPowerSumsI32). Each distinct (selection, grouping key, lane pair) is one pass. No new IR is needed, and integer lanes stay exact.let-bound planes on the contract set IR, after D-CMR-1:Plane(i)is immutable and bound to the coordinate version.call_owned's constant width.JoinDomain. No position is taken from another table's values.The plan also contains the worked ΣΣΣ factorization, the 256-rule CSE example, the recursion reuse, register and lazy-context integration, the benchmark that separates the three mechanisms, the risks with their falsifiers, and the stage order U0–U8.
Decisions recorded (operator, 2026-10-20)
lance-graph-contract. relalg keeps lowering and relational planning. No general relational AST is introduced for JC or Quack.Acceptance for U1 and U2 is measured row traversals, materializations and total cost, with the result set and version semantics unchanged. The 256-rule and 256-hop benchmarks stay separate.
Not yet fully verified
Three negatives rest on grep plus directory listings, not on a full read. The plan marks each one:
Board
ISS-ADMISSION-PREP-BINDINGshows the decided status.2026-10-20-d-relalg-unifiedare added; the entries index is regenerated.Generated by Claude Code