Skip to content

Ledger revision (d) against #1592–#1634 - #1636

Merged
AdaWorldAPI merged 2 commits into
mainfrom
claude/eager-albattani-iufugq
Oct 20, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
claude/eager-albattani-iufugq

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Research and board only; no code changed.

.claude/research/2026-10-recovery/LEDGER-REVISION-2026-10-20d.md continues the recovery ledger from revision (c), which ended at #1591. It covers 43 merged PRs (#1592–#1634), read through ten Haiku substrate-mapper maps. Every file:line it cites was then read on main (abfa9e2).

Closed (C39–C52)

  • CE64 bit fields:
    • 43..45 is the orientation field (C39).
    • 46..49 is activation i4 (C40). D-46 was decided the opposite way from revision (c)'s recommendation.
    • W is the thought layer (C41).
    • CE64 is an ISA contract, not a storage contract (C42).
  • call_owned removes the relalg width limit: an Or or And of any width now runs in 3 slots (C44).
  • Crepe as a cold optimizer in front of relalg: verdict PARTIALLY (C45). The addressed Lance read, Arm B, is measured (C46).
  • Also recorded: the MORK and RelationshipMap probes, the D-RMAP-2 tiers, the P-pool probe, the ACT-R kernel, the Post-merge recovery for #1601–#1617 #1618 recovery and the Haiku limits.

Merged into one item

  • ADMISSION combines GATHER-DECISION, ISS-ADMISSION-PREP-BINDING and ISS-GATHER-HOP-1616. It is one ruling on what a read during preparation may do, and Arm B is its measured worked example.
  • PROVENANCE and RECURSION each fold several blocked items into one.

Narrowed

  • After call_owned, the 8-slot budget limits only nesting depth, not width.

New open items

  • ISA-LEGACY: move isa.rs's opcode reading of 46..49 behind a declared legacy reading.
  • Stale STATUS rows: D-CGW-9, D-CMR-2, D-CGW-0.
  • FLOAT-REFS: git branch dependencies. Core's default build reaches OGAR main through lance-graph-r2il.
  • AGENT-CARDS: two cards have no frontmatter, so they never load.
  • ARM-B-PREPARE.
  • ACTION-GATE, corrected: neither gate has an admin bypass, and with required_role = None both skip RBAC.

Withdrawn from my earlier session report

  • That STATUS rows D-CMR-0 and D-RA-1 still read "In PR".
  • That D-CMR §3.2 is wrong.
  • That commit has an admin bypass.

Operator decisions still open: ADMISSION, D-RA-2, WIRE-50, ACTION-GATE, FLOAT-REFS, O30.

The board entry, the regenerated entries index and the regenerated supersession index (no change) are in the same commit.


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 130afe5c-5cd2-40f7-9793-c3ad3dbe3c16
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 20, 2026 22:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T22:18:26.986577Z 47e4ec5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Add Carrot credits or activate Agent usage billing to use Autofix

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47e4ec5ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/research/2026-10-recovery/LEDGER-REVISION-2026-10-20d.md Outdated
AdaWorldAPI pushed a commit that referenced this pull request Oct 20, 2026
…ange reads

attest -> read_keys scans both key columns of every row (addressed.rs:100-117,
7-10 ms for 100,002 keys); the 3k count is only the per-query range reads
(SideIo.rows_scanned). K13, C46 and the ADMISSION recommendation now name
both costs. Codex review on #1636.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
@AdaWorldAPI
AdaWorldAPI force-pushed the claude/eager-albattani-iufugq branch from ed17fa7 to 3c97d92 Compare October 20, 2026 22:34
AdaWorldAPI pushed a commit that referenced this pull request Oct 20, 2026
…ange reads

attest -> read_keys scans both key columns of every row (addressed.rs:100-117,
7-10 ms for 100,002 keys); the 3k count is only the per-query range reads
(SideIo.rows_scanned). K13, C46 and the ADMISSION recommendation now name
both costs. Codex review on #1636.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA

Copy link
Copy Markdown
Owner Author

Rebased onto main (43f711a, after #1635 and #1637).

main itself now fails the entries-index falsifier: python3 .claude/tools/entries_index.py --check reports DUPLICATE ID: D-RMAP-DIR-1 (2 rows). The two entries from #1635/#1637 (…-membership-closure-focus.md and …-round-2-focus-geometry.md) both start their heading with D-RMAP-DIR-1. This PR did not cause it, but it would go red on that check anyway.

Fixed here the same way #1627 named its re-run (D-RMAP-2-AMX-RERUN): the round-2 heading now reads D-RMAP-DIR-1-R2 (round 2 of D-RMAP-DIR-1): …. Its index row was regenerated from that heading. The entry body is unchanged. --check passes, and the supersession index is unchanged. If the owner session prefers a different id, this one-line change gives way to theirs.


Generated by Claude Code

Maps 43 merged PRs onto the recovery ledger (revision c ended at #1591).
Read through ten Haiku substrate-mapper maps, checked against main abfa9e2.
Closes C39-C52; merges the gather ruling and ISS-ADMISSION-PREP-BINDING
into one ADMISSION item with Arm B as its measured example; narrows the
slot budget to nesting depth after call_owned; records stale STATUS rows,
git branch refs in the default build and two cards without frontmatter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
…ange reads

attest -> read_keys scans both key columns of every row (addressed.rs:100-117,
7-10 ms for 100,002 keys); the 3k count is only the per-query range reads
(SideIo.rows_scanned). K13, C46 and the ADMISSION recommendation now name
both costs. Codex review on #1636.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
@AdaWorldAPI
AdaWorldAPI force-pushed the claude/eager-albattani-iufugq branch from 3c97d92 to a8b72ee Compare October 20, 2026 22:36

Copy link
Copy Markdown
Owner Author

Rebased onto main 29e5976. #1638 fixed the duplicate D-RMAP-DIR-1 id upstream (D-RMAP-DIR-1-R2), so I dropped my copy of that fix. This PR now touches only its own three files: the ledger revision, its board entry and the regenerated index row.


Generated by Claude Code

@AdaWorldAPI
AdaWorldAPI merged commit a17a1a9 into main Oct 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants