Repository navigation
D-SRAM-2 spike: masked Lance 13 reads and the addressed semijoin #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,895
−30
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a31c61b
crepe-plan-probe: masked Lance 13 reads and the addressed semijoin
claude cc578f2
crepe-plan-probe: Arm A vs Arm B measurement by selectivity
claude d0f308a
crepe-plan-probe: Arm B measured by selectivity; row filter re-measured
claude 068afb8
thought-git: state what the probe implements
claude 42505f1
Address #1633 review: out-of-range constants, full reads, dataset ide…
claude 2fedea4
crepe-plan-probe: the relalg Or limit is a setting, 2k-1 slots
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: Crepe plan probe | ||
| # `crates/crepe-plan-probe` is excluded from the workspace (own [workspace], | ||
| # git deps on the crepe and MORK forks, lance 13 / lancedb 0.40), so no | ||
| # workspace job builds it. It runs from its own directory so the cargo config | ||
| # above it and its own `.cargo/config.toml` apply. It path-deps relalg, | ||
| # mask-risc, mork-pathmap-probe and lance-graph-contract (the ordered lane and | ||
| # facet keys of arm B), so changes there run it too. | ||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'crates/crepe-plan-probe/**' | ||
| - 'crates/lance-graph-relalg/**' | ||
| - 'crates/lance-graph-contract/**' | ||
| - 'crates/lance-graph-mask-risc/**' | ||
| - 'crates/mork-pathmap-probe/**' | ||
| - '.github/workflows/crepe-plan-probe.yml' | ||
| - 'rust-toolchain.toml' | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'crates/crepe-plan-probe/**' | ||
| - 'crates/lance-graph-relalg/**' | ||
| - 'crates/lance-graph-contract/**' | ||
| - 'crates/lance-graph-mask-risc/**' | ||
| - 'crates/mork-pathmap-probe/**' | ||
| - '.github/workflows/crepe-plan-probe.yml' | ||
| - 'rust-toolchain.toml' | ||
| workflow_dispatch: | ||
| permissions: | ||
| contents: read | ||
| jobs: | ||
| probe: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 60 | ||
| defaults: | ||
| run: | ||
| working-directory: crates/crepe-plan-probe | ||
| env: | ||
| CARGO_PROFILE_DEV_DEBUG: "0" | ||
| CARGO_INCREMENTAL: "0" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Setup rust toolchain (pinned by rust-toolchain.toml) | ||
| run: rustup show | ||
| # lance's build compiles .proto files: `protoc` alone is not enough, the | ||
| # well-known includes (libprotobuf-dev) are needed too. | ||
| - name: Install protoc and the protobuf includes (for lance) | ||
| run: sudo apt-get update && sudo apt-get install -y protobuf-compiler libprotobuf-dev | ||
| - run: cargo fmt --check | ||
| - run: cargo clippy --all-targets -- -D warnings | ||
| - run: cargo test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.