Repository navigation
Re-pin the arity-gap assertions: upstream closed the gap - #10
Merged
Merged
Conversation
Both pins fired exactly as designed when OGAR#265 landed the shared-core arity sweep, and both are re-pinned deliberately rather than relaxed. `scratch.rs` pinned the borrowed-opcode arity gap at 21 -- opcodes the core NAMED but gave no `stack_arity` row. The comment said it would "fail LOUDLY when upstream fixes it, at which point the number drops and this demands a deliberate re-pin". That is what happened. Now 1: `PROC_CALL`, which stays refused upstream because it is genuinely variadic (a call passes as many arguments as its procedure declares), not because anyone forgot it. `projection.rs`'s uncovered-function test is re-pinned for the SECOND time (first off `IF`, now off `PROC_DEF`/`WAIT`, both since covered) -- onto `PROC_CALL`/`RETURN`, which are still genuinely outside the table. It also gains a can-fire half asserting the previously-named functions ARE covered now, so "uncovered" keeps discriminating instead of becoming a label for whatever happens to be missing. Depends on OGAR#265; the path dep means CI here needs it merged first.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_adcb2c1d-ed39-4f7f-adfc-707dc1f53a12) |
AdaWorldAPI
marked this pull request as ready for review
August 11, 2026 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to OGAR#265, which closed the shared-core arity gap. Both pins here fired exactly as designed, and both are re-pinned deliberately rather than relaxed.
scratch.rspinned the borrowed-opcode arity gap at 21 — opcodes the core named but gave nostack_arityrow. Its comment said it would "fail LOUDLY when upstream fixes it, at which point the number drops and this demands a deliberate re-pin." That is what happened. Now 1:PROC_CALL, which stays refused upstream because it is genuinely variadic (a call passes as many arguments as its procedure declares), not because anyone forgot it.projection.rs's uncovered-function test is re-pinned for the second time — first offIF, now offPROC_DEF/WAIT, both since covered — ontoPROC_CALL/RETURN, still genuinely outside the table. It also gains a can-fire half asserting the previously-named functions are covered now, so "uncovered" keeps discriminating instead of becoming a label for whatever happens to be missing.cargo test -p blockly-abi: 69 passed, 0 failures.Generated by Claude Code