Skip to content

IAM plan V16: phases 1-3 landed; open items - #343

Merged
AdaWorldAPI merged 1 commit into
mainfrom
ccr-0455e606-wmtsor
Oct 10, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
ccr-0455e606-wmtsor

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

This updates the status of V16 (Active Directory emulation) in docs/DIRECTORY-SIMULATION-POC.md. Docs only.

Where each phase landed (lance-graph):

  • Phase 1, observe::from_graph: #1450
  • Phase 2, ad::project and ad::to_ldif: #1452
  • Phase 3, ldap::Server: #1453

Decisions made while building them:

  • Every entry carries dirSimOrigin: observed, mirrored, synthetic or simulated.
  • The relative name is CN=<objectGUID>, because no display name is read yet.
  • The LDAP handler takes bytes in and returns bytes out, so it opens no sockets.
  • Access is decided by the host's Authority.

Open items added to the plan:

  • Display names, which would replace the GUID-only relative name.
  • The host binary that runs the LDAP listener and connects Authority to the RBAC plug.
  • Objects under non-OU containers such as CN=Users, which currently appear at the domain root.

🤖 Generated with Claude Code

https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg


Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the V16 status to mark Graph user observation, AD projection and LDIF export, and the LDAP server as implemented.
    • Added details on directory markings, GUID-based RDNs, LDAP request handling, authorization checks, and hidden search-base behavior.
    • Expanded the list of open items, including display names, host integration, container support, and synthetic DNs for cloud-only users.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T14:36:17.006251Z d8c6045 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 3ea216e9-45f2-4700-b6b9-3920fff9e154

📥 Commits

Reviewing files that changed from the base of the PR and between 8e2a180 and d8c6045.


📒 Files selected for processing (1)
  • docs/DIRECTORY-SIMULATION-POC.md

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.



📝 Walkthrough

Walkthrough

The V16 status now records three implemented phases and documents LDAP handling details. The open-items list includes additional gaps in display names, host integration, container placement, and cloud-only user DNs.

Changes

Directory simulation documentation

Layer / File(s) Summary
Implemented phases and open items
docs/DIRECTORY-SIMULATION-POC.md
The status describes Graph user observation, AD projection and LDIF export, and the LDAP server. It records dirSimOrigin markings, GUID-based RDNs, byte-oriented LDAP handling, host Authority checks, and noSuchObject responses for hidden search bases. The open-items list adds display names, LDAP listener and RBAC host integration, non-OU containers, and a bindable synthetic DN for cloud-only users.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: claude


Merge Risk: ⚪ Minimal · up to d8c60

This documentation update introduces no established operational regression or merge-blocking issue.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the documentation update by identifying the V16 IAM plan, completed phases 1–3, and remaining open items.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


A rabbit reads the directory page
Three phases hop onto the stage
GUIDs mark each entry’s place
LDAP bytes move at their pace
Open questions wait in line
The rabbit stamps the docs: “All fine!”

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI merged commit 173de21 into main Oct 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants