Repository navigation
ogar-dir-sim: mailbox hosts and locations; ogar-az: the user's OneDrive - #341
Merged
Merged
Conversation
ExchangeDeployment becomes Deployment { on_premises host, online }:
Exchange Server or Stalwart on-premises, Exchange Online in the cloud.
host_of says where a recipient's mailbox is, the question a mail server
answers before accepting a message as local or relaying it. Stalwart has
no ExchangeGuid, so only Exchange Server with Exchange Online compares
one. MailboxLocation and MailboxLocationType carry what
Get-MailboxLocation reports (TenantGUID\MailboxGUID, the pair Graph
spells MBX:{guid}@{tenant}).
ogar-az adds Pull::UserDrive (GET /users/{id}/drive, Files.Read.All,
delegated per Microsoft) and user_drive, which accepts a drive only when
its owner is the user, so Spear can address a user's OneDrive from the
directory id.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
…ters §10) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
… drive by user id Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 13:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up to #340 carries the rework that was pushed after #340 had already merged with its first version. It is rebased onto
mainand contains exactly two commits.What
ogar-dir-sim::deployment.ExchangeDeploymentbecomesDeployment { on_premises, online }.MailboxHostnames where a mailbox lives:ExchangeServerorStalwarton-premises, orExchangeOnline.The constants are
EXCHANGE_SERVER,ONLINE,EXCHANGE_HYBRID,STALWARTandSTALWART_WITH_ONLINE.host_of(recipient)says where a recipient's mailbox lives:This is the question a mail server answers before it accepts a message as local or relays it.
The
ExchangeGuidis compared only for Exchange Server together with Exchange Online, because Stalwart has noExchangeGuid.MailboxLocation { host, kind, mailbox_guid }andMailboxLocationType(seven values) carry whatGet-MailboxLocationreports. Exchange names a locationTenantGUID\MailboxGUID, which is the same pair Graph spellsMBX:{guid}@{tenant}.ogar-az::mailbox.Pull::UserDrivereadsGET /users/{id}/drivewithFiles.Read.All.Pull::grantsays how a permission is granted. Microsoft lists the drive read as delegated only; the mailbox reads take an application permission.user_driveaccepts a drive only when itsowner.user.idis the user, and returns its id. Spear's drive scope can then address a user's OneDrive from the directory id. The upload itself is Spear's write.Docs.
DIRECTORY-SIMULATION-POC.mdV15 is rewritten for hosts and locations, with these open items:Accountonly wherehost_ofisStalwart.DIRECTORY-ADAPTERS-POC.md§10 adds the drive read.Tests
deployment.rshas 4 tests: the deployment table,host_ofper deployment, location types, and purposes.tests/mailbox.rsadds a drive test covering the URL, the permission, the delegated grant, the owner check and malformed bodies.host_of's deprovisioned case;host_of's online gate;ExchangeGuidonly for Exchange Server.fmtandclippy -D warningsare clean and the crate tests are green on Rust 1.99.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Generated by Claude Code