Repository navigation
Remove the vendored OGIT; read AdaWorldAPI/OGIT from a floating checkout - #336
Merged
Merged
Conversation
OGAR no longer carries vocab/imports/ogit, the SHA-pinned mirror of AdaWorldAPI/OGIT last taken at d0f489f. Tests read OGIT at its moving master from a checkout: OGIT_FORK_PATH, else OGIT next to OGAR, the convention lance-graph-ontology's real-OGIT tests already use (crates/ogar-from-schema/src/ogit_checkout.rs). A missing checkout is a setup error, not a skip. CI checks master out beside the build. - The MARS XSD oracle was OGAR's own and only sat inside the mirror. It moves to vocab/oracles/mars/ with its provenance. - nine_domains_lift_surface_round_trip keeps the round-trip strict and turns the per-domain file counts into floors: on master, Compliance already has 15 files against an exact pin of 9. - Docs point at the checkout. The lift catalogue keeps its counts as the dated d0f489f snapshot. DISCOVERY-MAP 2.14 D-OGIT-FLOATING records the decision. Against master at 2315167d: cargo fmt --all --check clean, cargo clippy --all-targets -D warnings clean, cargo test --workspace 1050 passed, 0 failed, 23 ignored. With OGIT_FORK_PATH pointing nowhere, the 27 OGIT-reading tests fail with the setup message and the other 28 ogar-from-schema tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VysoWJ6vsyg3wEGc5v7T5v
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
WalkthroughWarning Review details and warnings were omitted to fit the comment limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OGAR stops vendoring OGIT.
vocab/imports/ogit/is removed: 1997 files, a SHA-pinned mirror last taken atd0f489f. Tests now read AdaWorldAPI/OGIT at its movingmasterfrom a checkout, the way lance-graph-ontology's real-OGIT tests already do. This replaces #335, which re-vendored instead.crates/ogar-from-schema/src/ogit_checkout.rs.OGIT_FORK_PATHnames the checkout; otherwise it isOGITnext to OGAR. A missing checkout fails the test with a setup message instead of skipping it. Integration tests include the same file through#[path].include_str!reads of OGIT files become runtime reads through the locator. That coversxsd.rs,sgo.rs,ttl.rs,do_arm.rs,ttl_emit.rsand two integration tests. All of them are test-only, so no library code read the mirror.nine_domains_lift_surface_round_tripkeeps the round-trip strict but turns its exact per-domain file counts into floors. Onmaster, Compliance has 15 files against an exact pin of 9, so the exact pin would fail today.vocab/oracles/mars/, with its provenance. Two measured corrections: the Py3 script is 14 519 bytes, not the 14 504 the old record said, and the.adocregenerates byte-equal except for its:revdate:line.ci.ymlchecks out AdaWorldAPI/OGITmasterintoogit/and setsOGIT_FORK_PATH.lint.ymlneeds nothing, since clippy only compiles the tests.d0f489fsnapshot and names the five domains added since.D-OGIT-FLOATINGrecords the decision, its basis, and when to revisit it.Verification
Against OGIT
masterat2315167d:cargo fmt --all --check: clean.cargo clippy --all-targets -- -D warnings: clean.cargo test --workspace: 1050 passed, 0 failed, 23 ignored.ogar-from-schema: 55 tests, or 59 with--features xsd, the same count as before.OGIT_FORK_PATH=/nonexistent/OGIT, the 27 OGIT-reading tests fail with the setup message, and the other 28 pass.Merge order
Bardioc-rs reads this tree too. AdaWorldAPI/Bardioc-rs#8 moves it to the same checkout and works with or without this PR, so merge it first.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VysoWJ6vsyg3wEGc5v7T5v
Generated by Claude Code