Add HiroPort (0x000C): HIRO's ogit/_type wire names onto the automation concepts by AdaWorldAPI · Pull Request #333 · AdaWorldAPI/OGAR

AdaWorldAPI · 2026-10-10T10:04:43Z

What

HIRO puts every node's type on the wire as a string such as ogit/MARS/Machine. HiroPort maps those strings onto the nine 0x0CXX automation concepts that already exist, so a HIRO node dispatches on a u16. This is the dispatch table docs/HIRO-IN-CLASSES.md §3.1 describes. It also gives Bardioc-rs a way to meet spear on shared classids, since spear's only public contract is SpearPort.

Wire name	Concept
`ogit/MARS/Application`, `/Resource`, `/Software`, `/Machine`	`0x0C01`–`0x0C04`
`ogit/Automation/KnowledgeItem`, `/MARSNodeTemplate`, `/ActionHandler`, `/ActionApplicability`, `/Trigger`	`0x0C05`–`0x0C09`

App prefix 0x000C: the next free one after HubSpo's 0x000B. 0x0006 stays held for q2.
Nothing is minted. ogit/Automation/MAID has no alias on purpose: MAID has no concept, no workload needs one, and minting before a falsifier passes is enum explosion.
Docs: a 0x000C row in APP-CLASS-CODEBOOK-LAYOUT.md §2, and D-HIRO-PORT in DISCOVERY-MAP.md §2.13 with the decision, its scope and when to revisit it.

Tests

Test	What it pins
`hiro_classview_composes_canon_high_custom_low`	A machine composes to `0x0C04_000C`. Wire names are exact: no case folding and no OGIT CURIE spelling. MAID does not resolve.
`hiro_covers_exactly_the_automation_domain`	Every automation concept has a wire name and no alias leaves the domain, so a tenth automation concept fails until it gets a name
Existing prefix tests	`HiroPort` joins the render-prefix collision list and the `0x1000` reservation list

ogar-vocab: 174 unit tests and 6 doc tests pass on Rust 1.99. With the Trigger alias removed, both new tests fail and name automation_trigger (0x0C09).

A lance-graph PR follows that mirrors 0x000C as AppPrefix::Hiro in ogar_codebook.rs, the same way #1438 mirrored HubSpo.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VysoWJ6vsyg3wEGc5v7T5v

Generated by Claude Code

Summary by CodeRabbit

New Features
- Added support for recognizing nine HIRO automation types and mapping them to corresponding automation concepts.
Documentation
- Updated the application codebook and discovery guide to include HIRO support and its type mappings.

…on concepts HIRO puts the type of every node on the wire as a string such as "ogit/MARS/Machine". HiroPort maps those strings onto the nine 0x0CXX automation concepts that already exist, so a HIRO node dispatches on a u16 (docs/HIRO-IN-CLASSES.md §3.1). App prefix 0x000C is the next free one after HubSpo's 0x000B; 0x0006 stays held for q2. - ports.rs: HiroPort and HIRO_ALIASES, nine exact wire names. Nothing is minted. ogit/Automation/MAID has no alias on purpose: MAID has no concept and no workload needs one. - Tests: the port composes 0x0C04_000C for a machine; wire names are exact (no case folding, no OGIT CURIE spelling); MAID does not resolve; the port covers exactly the automation domain, so a tenth automation concept fails the test until it gets a wire name. Removing the Trigger alias turns both tests red. HiroPort joins the render-prefix collision list and the 0x1000 reservation list. - APP-CLASS-CODEBOOK-LAYOUT §2 row 0x000C; DISCOVERY-MAP §2.13 D-HIRO-PORT with the decision that Bardioc-rs meets spear through ports. ogar-vocab: 174 unit tests and 6 doc tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VysoWJ6vsyg3wEGc5v7T5v

chatgpt-codex-connector · 2026-10-10T10:04:52Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-10T10:06:57.118854Z	`2ebf8e8`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-10T10:05:01Z

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 65 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: f8f295d6-a824-4f2c-92e0-75bf42f4d9b1

📥 Commits

Reviewing files that changed from the base of the PR and between 2ebf8e8 and d19b4f8.

📒 Files selected for processing (1)

crates/ogar-vocab/src/ports.rs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: 428f2032-50bd-4b4f-9d33-ccb2cc57cf50

📥 Commits

Reviewing files that changed from the base of the PR and between 2fbae6e and 2ebf8e8.

📒 Files selected for processing (3)

crates/ogar-vocab/src/ports.rs
docs/APP-CLASS-CODEBOOK-LAYOUT.md
docs/DISCOVERY-MAP.md

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

Walkthrough

The change adds HiroPort with APP prefix 0x000C and nine aliases from HIRO wire names to existing automation concepts. Tests check alias lookup and prefix constraints. Documentation records the allocation and discovery entry.

Changes

HIRO port mapping

Layer / File(s)	Summary
HIRO aliases and allocation `crates/ogar-vocab/src/ports.rs`, `docs/APP-CLASS-CODEBOOK-LAYOUT.md`, `docs/DISCOVERY-MAP.md`	Adds `HiroPort` and nine exact wire-name aliases. Tests check alias resolution, case sensitivity, and prefix constraints. The documentation records the `0x000C` allocation; MAID remains unaliased.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to 2ebf8

No actionable issue is identified; the change is mergeable after normal checks.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely identifies the addition of HiroPort, its prefix, and its mapping of HIRO wire names to automation concepts.
Docstring Coverage		Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 1 files. (2 skipped: 2 u…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

_{A rabbit checks each HIRO name,
Nine aliases map the same.
Prefix twelve is written down,
MAID stays outside the bound.
Hop, the port is in the code!}

_{Comment @coderabbitai help to get the list of available commands.}

cargo fmt --all --check failed on #333: the MARSNodeTemplate and ActionApplicability alias tuples exceed the line width. Formatting only; ogar-vocab's 174 unit and 6 doc tests pass unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VysoWJ6vsyg3wEGc5v7T5v

AdaWorldAPI merged commit f5368c0 into main Oct 10, 2026
4 checks passed

Navigation Menu

Repository navigation

Add HiroPort (0x000C): HIRO's ogit/_type wire names onto the automation concepts - #333

Add HiroPort (0x000C): HIRO's ogit/_type wire names onto the automation concepts#333
AdaWorldAPI merged 2 commits into
mainfrom
claude/hiro-port

AdaWorldAPI commented Oct 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AdaWorldAPI commented Oct 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Tests

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AdaWorldAPI commented Oct 10, 2026 •

edited by coderabbitai Bot

Loading

chatgpt-codex-connector Bot commented Oct 10, 2026 •

edited

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading