Repository navigation
Rust 1.98.1 → 1.99.0; lance 13 / lancedb 0.40 (dormant pins) - #329
Merged
Merged
Conversation
…ned) Non-comment pins only (rust-toolchain.toml, rust-version, CI MSRV, Dockerfile images); historical comments untouched. lance/lancedb moved in lockstep with lance-graph (arrow 58 / datafusion 54 unchanged); lancedb 0.40.0 still needs `remote` to compile. Verification results follow in the PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 02:20
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the workspace-wide sweep that moves to Rust 1.99.0 and to lance 13 / lancedb 0.40 (lance-graph #1437, merged).
What changes
rust-toolchain.toml,rust-versionand the CI minimum Rust version move from 1.98.1 to 1.99.0. Only non-comment lines changed; historical comments are untouched.lance 12.*/lancedb 0.39.*to13.*/0.40.*, with a dated comment. arrow 58 and datafusion 54 stay where they are.remotefeature. I re-checked this on 0.40.0.Verified
cargo clippy --workspace --all-targets --keep-going -- -D warningson rustc 1.99.0 passes with 0 errors.🤖 Generated with Claude Code
https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
Generated by Claude Code