Skip to content

dir-sim exchange: Disable-RemoteMailbox sets the deprovision bits and nothing else - #327

Closed
AdaWorldAPI wants to merge 1 commit into
mainfrom
ccr-0455e606-wmtsor
Closed

AdaWorldAPI wants to merge 1 commit into
mainfrom
ccr-0455e606-wmtsor

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Problem

RemoteMailboxOp::Disable cleared targetAddress and the display type and type-details codes when it deprovisioned a remote mailbox. Hybrid Exchange does not do that. Disable-RemoteMailbox sets the deprovision bit in msExchRemoteRecipientType, and the routing address, the type codes, mail, mailNickname and proxyAddresses all stay.

Change

  • Disable keeps the routing address; only the mailbox state becomes Deprovisioned (code 8, plus the archive bits).
  • RemoteMailbox::new requires a routing address in every state: Enable and a completed move write it, and Disable leaves it.
  • The display type and type details depend on the kind only, not on the mailbox state.
  • is_recipient is unchanged: a deprovisioned mailbox is no mail recipient.

Tests

  • cargo test -p ogar-dir-sim: 30 passing. fmt --check and clippy -D warnings are clean.
  • lance-graph lance-graph-dir-sim tests pass against this branch (path dependency), including the offboarding regression.
  • Disable check: restoring the old Disable (clearing the routing address) fails lifecycle_transitions_land_on_listed_codes and no_two_ops_reach_the_same_recipient.

🤖 Generated with Claude Code

https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg


Generated by Claude Code

… nothing else

Disable used to clear targetAddress and the display / type-details
codes with the mailbox. It does not: it sets the deprovision bit, and
the routing address, the type codes, mail, mailNickname and
proxyAddresses stay. Every remote mailbox state therefore carries its
routing address, and the type codes no longer depend on the mailbox
state.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Closing: wrong premise. Disable-RemoteMailbox clears the recipient attributes and keeps only the deprovision bits in msExchRemoteRecipientType, which is what main already models (routing address and type codes absent once deprovisioned).


Generated by Claude Code

@AdaWorldAPI AdaWorldAPI closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants