Repository navigation
ogar-dir-sim: three-valued active and the one effective_active definition (V4) - #318
Conversation
…tion (V4) NodeState::active becomes Option<bool>: Some(true) enabled, Some(false) disabled, None unknown. An unknown flag is never read as enabled. effective_active(ad, entra) is the single cross-source definition, decided 2026-10-07: active iff at least one source is known and no known source says disabled; an unknown source abstains. The full 3x3 table is pinned, both source orders. Disable runs: reading unknown/unknown as enabled, and requiring both sources to say disabled, each fail the table. Docs: V4 closed by ruling; the AD<->Entra merge is still not wired. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 532c1998-f943-4115-a27f-2f8d336c4f1c) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: f3ddd025-15f1-4d18-b5a7-6f28dc3dd8ea) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Settles V4 ("active" across AD and Entra). The rule: active iff at least one source is known and no known source says disabled; an unknown source abstains.
NodeState.activebecomesOption<bool>:Some(true)enabled,Some(false)disabled,Noneunknown. Groups carrySome(true).effective_active(ad, entra) -> Option<bool>is the single definition of the cross-source rule, and is re-exported. Every executor must agree with it row for row.(ad_known ∨ entra_known) ∧ (¬ad_known ∨ ad_enabled) ∧ (¬entra_known ∨ entra_enabled).DIRECTORY-SIMULATION-POC.mdrecords V4 as closed by ruling. It also records that no path merges AD and Entra yet.Ordering
This PR must merge before lance-graph's companion PR (same branch name). lance-graph's dir-sim CI builds against OGAR
mainand useseffective_active/Option<bool>.Tests
change::tests::effective_active_is_the_v4_table.🤖 Generated with Claude Code
https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Generated by Claude Code