Skip to content

ogar-dir-sim: three-valued active and the one effective_active definition (V4) - #318

Merged
AdaWorldAPI merged 1 commit into
mainfrom
ccr-0455e606-wmtsor
Oct 7, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
ccr-0455e606-wmtsor

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Summary

Settles V4 ("active" across AD and Entra). The rule: active iff at least one source is known and no known source says disabled; an unknown source abstains.

  • NodeState.active becomes Option<bool>: Some(true) enabled, Some(false) disabled, None unknown. Groups carry Some(true).
  • effective_active(ad, entra) -> Option<bool> is the single definition of the cross-source rule, and is re-exported. Every executor must agree with it row for row.
    • Expression: (ad_known ∨ entra_known) ∧ (¬ad_known ∨ ad_enabled) ∧ (¬entra_known ∨ entra_enabled).
    • The 3×3 table is pinned, in both source orders.
  • Docs: DIRECTORY-SIMULATION-POC.md records V4 as closed by ruling. It also records that no path merges AD and Entra yet.

Ordering

This PR must merge before lance-graph's companion PR (same branch name). lance-graph's dir-sim CI builds against OGAR main and uses effective_active / Option<bool>.

Tests

  • change::tests::effective_active_is_the_v4_table.
  • Disable runs, each red:
    • unknown/unknown read as enabled;
    • negative evidence requiring both sources.

🤖 Generated with Claude Code

https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg


Generated by Claude Code

…tion (V4)

NodeState::active becomes Option<bool>: Some(true) enabled, Some(false)
disabled, None unknown. An unknown flag is never read as enabled.

effective_active(ad, entra) is the single cross-source definition, decided
2026-10-07: active iff at least one source is known and no known source
says disabled; an unknown source abstains. The full 3x3 table is pinned,
both source orders. Disable runs: reading unknown/unknown as enabled, and
requiring both sources to say disabled, each fail the table.

Docs: V4 closed by ruling; the AD<->Entra merge is still not wired.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 55a74271-a461-4707-aee4-16a9ae07bcb4
📥 Commits

Reviewing files that changed from the base of the PR and between e5de84e and c0975e8.

📒 Files selected for processing (4)
  • crates/ogar-dir-sim/src/change.rs
  • crates/ogar-dir-sim/src/lib.rs
  • crates/ogar-dir-sim/src/plan.rs
  • docs/DIRECTORY-SIMULATION-POC.md
 ___________________________________________________________________________
< In Vino Veritas, In Codice Bugas. In wine, there is truth; in code, bugs. >
 ---------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Oct 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 532c1998-f943-4115-a27f-2f8d336c4f1c)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 7, 2026 16:49
@AdaWorldAPI
AdaWorldAPI merged commit 6119504 into main Oct 7, 2026
5 checks passed
@cursor

cursor Bot commented Oct 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: f3ddd025-15f1-4d18-b5a7-6f28dc3dd8ea)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T16:50:00.610254Z c0975e8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants