Repository navigation
Record operator rulings: surface coverage classes, new D-ids, packed-run RBAC grain - #41
Merged
Merged
Conversation
…run RBAC grain surface_map.tsv gains a coverage column (planned / deferred / out-of-scope / unclassified) that must agree with the deliverable; the committed-map test pins planned 1,161, deferred 329, out of scope 16 of 1,506 functions. The 19 former UNPLANNED families move to new D-MKT-5, D-EXT-1 (deferred), D-DOC-1, D-OPS-1, D-DATA-1, or fold into D-FLOW-2, D-ONT-7, D-COM-1, D-QRY-6, D-MKT-4; partner program and API metadata are out of scope. ISS-PACKED-RUN-RBAC-GRAIN decided as option (b): authorization is per property; requirements recorded on the D-IAM-3 row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
AdaWorldAPI
marked this pull request as ready for review
October 21, 2026 00:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b89a6a13b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
D-DATA-1, D-DOC-1, D-MKT-5, D-EXT-1 and D-OPS-1 were on the board but not in the canonical plan (Codex on #41). The feature matrix gains rows 3.21, 6.15, 8.19, 8.20; 8.14 now names D-EXT-1. Coverage summary recomputed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
A family may be marked implemented only when its D-id is Shipped on STATUS_BOARD (surface::check_board); none is today. D-DOC-1 is HubSpot Files API compatibility in hubspo-docs over spear (plan §2.5.1), Blocked on spear document records, references and authorization (ISS-SPEAR-DOCUMENT-CONTRACTS) and D-DELIVER-2..6. spear verified at c69cacb: content store implemented, UploadIntent/DriveScope types only, Graph transport a stub, delivery plan unbuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the operator's 2026-10-21 rulings on scope, ownership and coverage. This PR adds no feature code: it changes only the map, the guard and the plan.
Surface coverage (
ISS-SURFACE-COVERAGE-SEMANTICS, resolved here)data/hubspot/surface_map.tsvgains acoveragecolumn with five values: planned / implemented / deferred / out-of-scope / unclassified.surface::parse_maprejects a row whose class disagrees with its deliverable:UNPLANNED⇔ unclassified,NONE⇔ out-of-scope, and a D-id for planned, implemented or deferred.surface::check_boardacceptsimplementedonly when the D-id is Shipped on STATUS_BOARD. A Shipped D-id never makes its API count as served on its own.Pinned counts, 1,506 functions in total:
ISS-SURFACE-UNPLANNED(decided)D-DOC-1 is bounded to
hubspo-docsover spear (plan §2.5.1)spear
mainc69cacbwas read and classified:UploadIntent,DriveScope(no user drives)DeliveryIntent, Entra resolution, delivery RBAC, receipts,activity/send_receiptsISS-SPEAR-DOCUMENT-CONTRACTSand on D-DELIVER-2..6. It builds no content store, version history, Graph client, authorization model or receipt model.ISS-PACKED-RUN-RBAC-GRAIN(decided: option b)Authorization is per property, keyed by the stable table ordinal and independent of the packed run. Option (c) is defense in depth, not a substitute. The contract follows in the D-IAM PR.
Verification
cargo fmt --check,cargo clippy -D warningsandcargo test --workspaceare green.🤖 Generated with Claude Code
https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z