test: concurrent GrantRole/RevokeRole vs AddOwner/RemoveOwner matrix - #734
Merged
thegreatfeez merged 1 commit intoOct 1, 2026
Merged
Conversation
Fixes a handful of pre-existing test.rs bugs blocking compilation (missing brace, stale call signatures, duplicate test names, a testutils API mismatch) and adds a combinatorial test matrix covering GrantRole/RevokeRole proposals against AddOwner/RemoveOwner in both execution orders, asserting deterministic final role/owner state and that removed owners end up holding no roles.
|
@ppaker119 is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ppaker119 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #596
Summary
GrantRole/RevokeRoleproposals againstAddOwner/RemoveOwnerproposals, executed in both orders, to thesetup_matrixquorum-combination suite incontracts/accord/src/test.rs.test.rsthat were blockingcargo testfrom compiling at all onmain: a missing closing brace, a few call sites using stale/outdated method signatures, two duplicate test function names, and a couple ofenv.events()/Symbolcalls using an API shape the pinnedsoroban-sdkversion doesn't expose. None of these are related to the role/owner matrix itself — they were just in the way.Notable findings surfaced by the new matrix
GrantRoleexecuting after a target'sRemoveOwnerstill succeeds (roles aren't owner-gated —Vieweris explicitly grantable to non-owners elsewhere in the suite), so a removed owner can end up holding a role again if a role proposal targeting it resolves afterward. This is covered and asserted as current, deterministic behavior rather than treated as a bug fix.AddOwner's execute path assigns the default role set by full overwrite rather than merge, so aGrantRolethat lands before a target becomes an owner is silently lost onceAddOwnerexecutes, whereas the reverse order keeps it. Both orders are covered explicitly.Test plan
cargo check --testspasses forcontracts/accord.cargo test(not run in this environment — please confirm in CI).