#727 Fix parsing of '88 VALUE1 VALUE +999.9999.' statement that threw 'SytnaxErrorException'.

[yruslan]

Closes #727

Summary by CodeRabbit

• New Features

  • Added support for optionally signed numeric literals with explicit decimal notation in COBOL copybooks.
  • Improved parsing of precision-9 decimal values in PIC clauses.

• Bug Fixes

  • Valid explicit-decimal PIC definitions, including condition-name entries, are now parsed correctly.

[github-actions]

JaCoCo code coverage report - 'cobol-parser'

Overall Project	90.07% -0.67%	🍏
Files changed	57.21%	🍏

File	Coverage
copybookParser.java	51.99% -4.84%	🍏

[github-actions]

JaCoCo code coverage report - 'spark-cobol'

Overall Project	83.52%	🍏

There is no coverage information present for the Files changed

[coderabbitai]

Walkthrough

The ANTLR grammar now accepts optionally signed PRECISION_9_EXPLICIT_DOT literals. The generated parser was regenerated, and syntax coverage was added for explicit decimal PIC and condition-name values.

Changes

Explicit decimal parsing

Layer / File(s)	Summary
Numeric literal grammar contract cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/antlr/copybookParser.g4	The numericLiteral rule accepts an optional sign before PRECISION_9_EXPLICIT_DOT.
Generated parser and syntax coverage cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/antlr/copybookParser.java, cobol-parser/src/test/scala/za/co/absa/cobrix/cobol/parser/parse/SyntaxErrorsSpec.scala	The generated parser includes the new numeric literal branch and regenerated state data. Tests cover +999.9999 and explicit decimal condition-name values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a rabbit parsing dots,
Signed nines in proper slots.
PIC fields now pass the gate,
Condition values parse straight.
Hop, hop—syntax fixed!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the parsing fix and references the failing COBOL statement from issue #727.
Linked Issues check	✅ Passed	The grammar now accepts signed explicit-decimal literals, and tests cover +999.9999 and +951.22 required by issue [#727].
Out of Scope Changes check	✅ Passed	The changes are limited to the parser grammar, regenerated parser, and targeted syntax tests for the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/727-parse-999-9999-values

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/antlr/copybookParser.java`:
- Around line 3866-4067: Configure the ANTLR4 Maven generation task in pom.xml,
adding the ANTLR plugin and grammar source setup so copybookParser.g4 generates
copybookParser.java during the build before compilation. Keep the generated
parser synchronized with the grammar and retain antlr4-runtime for runtime
usage.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b25ae6e1-aa7a-45ba-b16c-7c866a52326b

📥 Commits

Reviewing files that changed from the base of the PR and between b017ff9 and 7bf354f.

📒 Files selected for processing (3)

• cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/antlr/copybookParser.g4
• cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/antlr/copybookParser.java
• cobol-parser/src/test/scala/za/co/absa/cobrix/cobol/parser/parse/SyntaxErrorsSpec.scala

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check whether ANTLR4 code generation is wired into the build,
# so this generated parser file is produced automatically rather than hand-edited.
set -euo pipefail

echo "== Search build files for antlr4 plugin configuration =="
rg -n -i 'antlr' --glob 'build.sbt' --glob '*.sbt' --glob 'pom.xml' --glob 'plugins.sbt' . 2>/dev/null || true

echo "== Locate the grammar file and generated parser to compare timestamps/paths =="
fd -a 'copybookParser.g4'
fd -a 'copybookParser.java'

Repository: AbsaOSS/cobrix

Length of output: 1002

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== cobol-parser/pom.xml relevant sections =="
wc -l cobol-parser/pom.xml build.sbt
sed -n '1,220p' cobol-parser/pom.xml

echo
echo "== build.sbt ANTLR references with context =="
sed -n '55,170p' build.sbt

echo
echo "== ANTLR plugin references in repository =="
rg -n -i 'antlr4-maven-plugin|org.antlr.apache|antlr4|antlr' --glob 'pom.xml' --glob '*.xml' --glob '*.sbt' --glob 'build.groovy' --glob '*.gradle' .

Repository: AbsaOSS/cobrix

Length of output: 7324

---

Wire the generated parser into ANTLR4 code generation.

cobol-parser/pom.xml only declares antlr4-runtime, and the ANTLR plugin is not configured. Add an ANTLR4 build task that generates copybookParser.java from copybookParser.g4 before committing the regenerated parser file.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/antlr/copybookParser.java`
around lines 3866 - 4067, Configure the ANTLR4 Maven generation task in pom.xml,
adding the ANTLR plugin and grammar source setup so copybookParser.g4 generates
copybookParser.java during the build before compilation. Keep the generated
parser synchronized with the grammar and retain antlr4-runtime for runtime
usage.