Repository navigation
Fix SDK nightly validation, SWIG compatibility, and CI runners - #32
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
schaubh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK nightly validation has failed since October 31 because its smoke test expects the old recorder ownership implementation. Accept both the pinned Basilisk revision's direct message retention and the latest nightly's storage-owner retention, while still requiring the recorder keep-alive hook.
After that assertion was corrected, the example extension exposed a second failure: SWIG 4.4.1 generated an incompatible module initializer for the current Basilisk sources on Python 3.14. Pin SWIG 4.5.1 in the SDK and example, and align the CMake diagnostic, synchronization fixture, and contributor guidance.
Pin Linux CI runners to Ubuntu 24.04 because
ubuntu-latestnow uses Ubuntu 26.04, whereactions/setup-pythoncannot install Python 3.9. Keep the build/test/example matrices, Rust MSRV runner, and artifact reference aligned.The affected surfaces are packaging/build dependencies, SDK validation, and CI runner selection. Extension authors now receive SWIG 4.5.1, retaining runtime epoch 5. The SDK version and recorded Basilisk submodule commit are unchanged.
Local validation on macOS arm64 / Python 3.14:
2ec3209dca5bde79101f8d7bfdb5a47b8c296946and published nightly source016955fba0117ac52eb58f91121668556dcca290, usingtools/sync_all.py --basilisk-root <checkout>andBSK_SDK_AUTO_SYNC=0 python -m build --wheel --no-isolation.python -m pytest tests -q: 88 passed against each SDK wheel.python -m build --wheel --no-isolation examples/custom-atm-extension: C++/Rust extension wheel built against the published nightly.python -m pytest examples -q: 30 passed; Basilisk, Numba, and extension imports passed.git diff --check: passed.GitHub CI passed all 19 jobs on commit
41bc6d5: wheel builds, SDK tests, and C++/Rust example builds and tests on Linux, macOS, and Windows with Python 3.9 and 3.14, plus the Rust minimum-toolchain build, native tests, Clippy, formatting, and license checks. Successful CI run.