Repository navigation
Align BSK-SDK 2.13 beta with Eigen 5.0.1 - #31
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
schaubh
force-pushed
the
feature/eigen-5.0.1
branch
from
October 26, 2026 15:46
4095948 to
b4a819d
Compare
schaubh
added a commit
that referenced
this pull request
Oct 27, 2026
schaubh
added a commit
that referenced
this pull request
Oct 27, 2026
schaubh
added a commit
that referenced
this pull request
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update SDK packaging and CMake/SWIG helpers to bundle Eigen 5.0.1, matching current Basilisk development builds. Require exactly 5.0.1 for local Eigen discovery and reject incompatible headers during extension compilation, including headers supplied by parent CMake projects.
Require C11 when compiling the shared SDK runtime so current Basilisk sources using
_Static_assertbuild with MSVC. Add regression coverage for parent projects selecting C99 or C17, alongside coverage for bundled Eigen headers, imported targets, aliases, and include overrides. Update the Rust binding fixture and document the Eigen requirement.The affected surfaces are packaging, CMake/SWIG, tests, and documentation. The SDK remains at
2.13.0b0, and the recorded Basilisk submodule commit is unchanged. Beta builds use matching nightly or explicitly selected Basilisk sources. Extension authors should rebuild their wheels when updating Eigen; the SDK handles its runtime's C11 requirement automatically.Validation:
c0e9552f794df5cb122091a86340ffc4700a5e2e: SDK builds, installed-wheel tests, and example-extension tests on Linux, macOS, and Windows with Python 3.9 and 3.14, plus the Rust minimum-toolchain job. CI runpytest tests -q -p no:rerunfailures: 88 passed against the rebuilt SDK wheel.pytest examples -q -p no:rerunfailures: 30 passed against the rebuilt example wheel.linearAlgebra.cwhile retaining C99 for the consumer's C source.git diff --check: passed.No CI matrix checks remain skipped.