Repository navigation
[Issue #370] End downlink actions when the buffer empties - #371
Merged
Merged
Conversation
dhutererprats
marked this pull request as ready for review
November 4, 2026 01:55
LorenzzoQM
reviewed
Nov 4, 2026
LorenzzoQM
reviewed
Nov 4, 2026
LorenzzoQM
reviewed
Nov 4, 2026
LorenzzoQM
reviewed
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #370
Summary
Adds an opt-in way for a downlink action to end when the satellite's data buffer becomes empty. This lets a variable-interval environment request another action without waiting for the configured downlink duration to expire.
Enable it with:
Existing
act.Downlink()configurations keep their current fixed-duration behavior.Behavior
minimum_durationseconds have elapsed. The default is 10 seconds. If the simulator step is longer, the action waits at least one simulator step.empty_storage_threshold_bitsdefaults to 1 bit to account for small residual values.Example:
Changes
Downlinkwith opt-in variable-duration settings and an empty-buffer terminal event.Validation