Repository navigation
Feature/hybrid actions - #369
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
15e2422 to
9c2b916
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
9c2b916 to
c56eb13
Compare
dhutererprats
left a comment
There was a problem hiding this comment.
Left a few comments. Not sure what the planned final implementation and thinking is between desired action duration that an agent dictates vs desired capture time with +- tolerances. Best capture timing only applies when we value quality of the image in some form as different at one time vs another time.
c56eb13 to
fc92425
Compare
dhutererprats
left a comment
There was a problem hiding this comment.
Nice, all looks good to me now. Thanks for the useful addition with this PR!
Description
Closes #363
This PR adds optional hybrid action spaces that pair a discrete action selection with a requested duration. For ground imaging, the continuous parameter instead specifies a desired capture-time offset from the current simulation time, with configurable lower and upper timing tolerances in the instrument controller.
Hybrid mode is disabled by default, preserving the existing discrete action format. Both timing tolerances also default to zero (disabled), preserving prior imaging behavior.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
New integration and unit tests were added to cover the new functionalities.
Future Work
RSO imaging does not support the hybrid option, as it can conflict with the gating being used. This can be updated once issue #358 is closed.
Checklist