Skip to content

Feature/hybrid actions - #369

Merged
LorenzzoQM merged 4 commits into
developfrom
feature/hybrid_actions
Nov 3, 2026
Merged

LorenzzoQM merged 4 commits into
developfrom
feature/hybrid_actions

Conversation

@LorenzzoQM

Copy link
Copy Markdown
Contributor

Description

Closes #363

This PR adds optional hybrid action spaces that pair a discrete action selection with a requested duration. For ground imaging, the continuous parameter instead specifies a desired capture-time offset from the current simulation time, with configurable lower and upper timing tolerances in the instrument controller.

Hybrid mode is disabled by default, preserving the existing discrete action format. Both timing tolerances also default to zero (disabled), preserving prior imaging behavior.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

New integration and unit tests were added to cover the new functionalities.

Future Work

RSO imaging does not support the hybrid option, as it can conflict with the gating being used. This can be updated once issue #358 is closed.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@LorenzzoQM LorenzzoQM self-assigned this Oct 23, 2026
Copilot AI balanced review requested due to automatic review settings October 23, 2026 22:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@LorenzzoQM
LorenzzoQM marked this pull request as draft October 23, 2026 22:40
@LorenzzoQM
LorenzzoQM force-pushed the feature/hybrid_actions branch from 15e2422 to 9c2b916 Compare October 23, 2026 22:46
@LorenzzoQM
LorenzzoQM requested a balanced review from Copilot October 24, 2026 00:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@LorenzzoQM
LorenzzoQM force-pushed the feature/hybrid_actions branch from 9c2b916 to c56eb13 Compare October 27, 2026 03:07
@LorenzzoQM
LorenzzoQM marked this pull request as ready for review October 27, 2026 03:18

@dhutererprats dhutererprats left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Not sure what the planned final implementation and thinking is between desired action duration that an agent dictates vs desired capture time with +- tolerances. Best capture timing only applies when we value quality of the image in some form as different at one time vs another time.

Comment thread src/bsk_rl/act/discrete_actions.py Resolved
Comment thread src/bsk_rl/act/discrete_actions.py Resolved
Comment thread src/bsk_rl/act/discrete_actions.py Resolved
Comment thread src/bsk_rl/act/discrete_actions.py Resolved
Comment thread src/bsk_rl/sim/fsw/ground_imaging.py Resolved
Comment thread src/bsk_rl/act/discrete_actions.py Resolved

@dhutererprats dhutererprats left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, all looks good to me now. Thanks for the useful addition with this PR!

@LorenzzoQM
LorenzzoQM merged commit 57eaace into develop Nov 3, 2026
8 checks passed
@LorenzzoQM
LorenzzoQM deleted the feature/hybrid_actions branch November 3, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hybrid action space option

3 participants