Skip to content

Feature/configurable attitude rso - #362

Merged
AfrahGh merged 4 commits into
developfrom
feature/configurable_attitude_RSO
Oct 9, 2026
Merged

AfrahGh merged 4 commits into
developfrom
feature/configurable_attitude_RSO

Conversation

@AfrahGh

@AfrahGh AfrahGh commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Description

Closes #355

This PR makes the chief/RSO initial attitude and spin configurable in the RSO inspection environment while preserving the existing nadir-pointing behavior as the default.

The changes include:

  • Adds hill_frame_attitude, a reusable utility for generating an initially Hill-aligned attitude and body rate.
  • Adds RSO attitude and angular-rate observations:
    • rso_sigma_BH: RSO body attitude relative to its Hill frame, represented as MRPs.
    • rso_omega_BH: RSO body angular velocity relative to its Hill frame, expressed in Hill-frame coordinates.
  • Updates the RSO inspection example to demonstrate how spin_config is set and bound to the satellite argument randomizer.
  • Documents the feature in the release notes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

  • Added tests/unittest/utils/test_attitude.py to test default nadir pointing, configurable spin rates and axes, and invalid configurations.
  • Updated tests/unittest/obs/test_relative_observations.py to test rso_sigma_BH and rso_omega_BH.
  • Updated tests/integration/test_int_rso_env.py to verify the new RSO observations are present, finite, and correctly shaped.

All tests pass.

Future Work

No additional work is required

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@AfrahGh
AfrahGh requested a review from LorenzzoQM October 9, 2026 19:58

@LorenzzoQM LorenzzoQM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AfrahGh
AfrahGh merged commit 93a0ee4 into develop Oct 9, 2026
8 checks passed
@AfrahGh
AfrahGh deleted the feature/configurable_attitude_RSO branch October 9, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add configurable target attitude dynamics to RSO inspection

2 participants