Skip to content

Feature/325 Make target location uncertainty example script - #327

Merged
Yume27 merged 2 commits into
developfrom
feature/325-target-uncertaity
Nov 9, 2026
Merged

Yume27 merged 2 commits into
developfrom
feature/325-target-uncertaity

Conversation

@Yume27

@Yume27 Yume27 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Description

Closes #325

Included an example script demonstrating target location uncertainty modeling with uncertainty growth over time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New example script.

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

The code has been successfully run using the latest version of BSK-RL.

Future Work

N/A

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copilot AI review requested due to automatic review settings December 18, 2025 18:47
@Yume27 Yume27 linked an issue Dec 18, 2025 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new example Jupyter notebook demonstrating target location uncertainty modeling in BSK-RL. The example shows how to model uncertainty in target locations when imaging ground targets and how this uncertainty grows over time when targets are not imaged.

Key Changes:

  • Implementation of a custom reward function that balances target priority with location uncertainty
  • Custom environment that updates target uncertainty dynamically over time based on target movement
  • Demonstration of duration-based imaging with uncertain target locations

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.

File Description
examples/target_location_uncertainty.ipynb New example notebook demonstrating target location uncertainty modeling with classes for uncertain targets, uncertainty-aware rewards, custom satellite configuration, and dynamic uncertainty growth
examples/_default.rst Added the new example to the documentation index
docs/source/release_notes.rst Added release note entry for the new example script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/source/release_notes.rst Resolved
@Yume27
Yume27 marked this pull request as draft December 18, 2025 18:59
@Yume27
Yume27 force-pushed the feature/325-target-uncertaity branch 4 times, most recently from b256857 to 1de6fe1 Compare December 18, 2025 21:00
@Yume27
Yume27 force-pushed the feature/325-target-uncertaity branch 2 times, most recently from 39e625d to 28ccc33 Compare November 4, 2026 00:58
@Yume27
Yume27 force-pushed the feature/325-target-uncertaity branch from 28ccc33 to 27fafcb Compare November 4, 2026 01:05
@Yume27
Yume27 marked this pull request as ready for review November 4, 2026 01:21
@Yume27
Yume27 requested a review from AfrahGh November 4, 2026 01:21
@Yume27
Yume27 merged commit 8ae1ffd into develop Nov 9, 2026
8 checks passed
@Yume27
Yume27 deleted the feature/325-target-uncertaity branch November 9, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make target location uncertainty example script

3 participants