You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Replace the space-imaging acquisition gate with Basilisk simpleInstrumentController #358
The space-to-space imaging work in PR #356 currently keeps acquisition constraints in a temporary BSK-RL gate. We agreed to use that approach while the Basilisk simpleInstrumentController extension is reviewed, so the BSK-RL feature can continue with the existing controller API.
The upstream request is Basilisk #1602. Once the corresponding change is merged and available, replace the temporary _AcquisitionGate in src/bsk_rl/sim/fsw/rso_imaging.py with the updated native controller.
The follow-up should:
Move pointing, rate, access, illumination, and continuous/cumulative hold checks into simpleInstrumentController and remove the Python implementation of those checks.
Keep physical storage confirmation and the image ledger in BSK-RL. Preserve target IDs, capture time, valid hold time, and time-weighted mean illumination in acquisition records.
Preserve a single image command, fresh guidance after switching targets, storage-capacity handling, cancellation, and the exclusive action deadline.
Keep the public ImageRSO configuration and reward behavior consistent. Reuse the current physical tests for hold interruptions, zero holds, target switching, partial downlinks, and repeated resets, and execute both notebook modes.
Identify and test a Basilisk commit containing the extension. Update installation/CI instructions for development builds, and set the packaged minimum version when a release containing it exists.
This issue tracks replacing the temporary controller logic. The broader imaging feature remains covered by #357. The current BSK-RL PR does not require this new controller API; the version requirement changes when we adopt it.
Activity
[#357] Address space-imaging review feedback
[#357] Gate RSO acquisition before physical image storage
[#357] Gate RSO acquisition before physical image storage
[#357] Gate RSO acquisition before physical image storage