Repository navigation
Conversation
- Accept prefixed and default CCSDS namespaces. - Reject duplicate OMM fields and blocks while preserving record diagnostics. - Add namespace and collision regressions; update the beta feature release note. Validation: 874 tests passed, along with pre-commit and focused Sphinx checks.
- Normalize the exact alias to SGP4 across all four encodings. - Preserve existing physical metadata and ephemeris-type validation. - Expand regression coverage and update the original OMM beta release note. Validation: 990 tests passed, plus pre-commit and focused Sphinx checks.
schaubh
added
bug
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was
linked to
issues
Nov 10, 2026
Preserve missing, null and blank catalog numbers as empty public metadata while retaining validation of supplied IDs and duplicate fields. Add regressions for all four encodings, both SGP4 backends, multiple unidentified records, and OMM 3.0 without catalog metadata. Update the original OMM beta release note. Validation: 2128 related tests passed; focused Sphinx build and pre-commit checks passed.
Verify that JSON integer zero remains a catalog ID while false and floating-point zero are rejected before SGP4 initialization. Check that missing catalog IDs do not bypass orbital validation and that later valid records still load. Validation: 2132 related tests passed in 5.00 seconds; pre-commit checks passed.
This was referenced Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for CCSDS namespace-qualified OMM XML and CelesTrak’s
SGP/SGP4theory label while retaining the supported Earth-centered, TEME, UTC, SGP4 profile.Additional improvements include:
999999999, including leading plus signs and zeros.MPLCONFIGDIRsettings.The 13 commits separate compatibility changes, individual validation and metadata improvements, regression-test consolidation, and test-cache changes.
Verification
Added targeted regressions for namespace collisions, duplicate fields in both orders, XML placement and error boundaries, CSV handling, catalog IDs, designators, and derivative coefficients. Representative orbit tests compare against independently parsed TLE states using both SGP4 backends.
Reduced redundant test combinations while retaining distinct boundaries and integration coverage. Cache tests cover overrides, write failures, subprocess reuse, and symlinked directories.
Validation on macOS/Python 3.15:
The socket-using pytest rerun plugin was disabled for sandbox compatibility.
Documentation
Updated the OMM API documentation and original OMM beta release note to describe expanded capabilities, validation behavior, metadata handling, and derivative conventions.
Updated developer testing documentation and added a release note for the shared Matplotlib cache.
Future work
None