Repository navigation
Fix namespace-qualified CCSDS OMM XML parsing (#1669) - #1670
Draft
heathsanchez wants to merge 2 commits into
Draft
heathsanchez wants to merge 2 commits into
heathsanchez wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OMM XML reader used unqualified ElementTree tag paths, causing valid CCSDS NDM XML with the standard
urn:ccsds:schema:ndmxmlnamespace to produce zero satellite records. This patch accepts both the existing unqualified form and the CCSDS-qualified form, retains segment order and per-record validation positions, and continues to reject unrelated namespaces.The two commits separate the parser/test fix from additional rejection-boundary tests and the release-note snippet. The change is limited to
src/utilities/ommHandling.py,src/tests/test_readOMM.py, and the required release-note snippet.Verification
<segment>root remained rejected; 200/200 seeded unqualified XML differential cases matched the unmodified parser.py_compileandgit diff --checksucceeded; release-note snippet compilation completed.pytestand actual Basilisk/SGP4 integration. The available local environment lackspytest,sgp4, and the built Basilisk package. Please keep this PR in draft until repository CI and native tests pass.Documentation
Adds
docs/source/Support/bskReleaseNotesSnippets/1669-omm-xml-namespace.rstto record support for CCSDS namespace-qualified OMM XML.Future work
Run the native
test_readOMM.pyandtest_readTLE.pysuites in Basilisk's supported build/test environment, then review CI and promote from draft once green.