Skip to content

Updated go version from 1.20 to 1.26 - #165

Merged
soumeh01 merged 6 commits into
mainfrom
go-version-update
Jul 29, 2026
Merged

Updated go version from 1.20 to 1.26#165
soumeh01 merged 6 commits into
mainfrom
go-version-update

Conversation

@soumeh01

@soumeh01 soumeh01 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator
  • This change updates the Go version and the GitHub Actions versions. After the updates, the newer linter reported several additional findings, which have also been addressed in this change.
  • Dropped darwin amd64 support

Please note that the linter fixes were generated with AI assistance.

@soumeh01
soumeh01 force-pushed the go-version-update branch from 3c2337a to a064709 Compare July 16, 2026 12:49
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Test Results

    3 files     21 suites   0s ⏱️
1 215 tests 1 215 ✅ 0 💤 0 ❌
3 645 runs  3 645 ✅ 0 💤 0 ❌

Results for commit 201c75b.

♻️ This comment has been updated with latest results.

@soumeh01
soumeh01 force-pushed the go-version-update branch from a064709 to 2c80c5c Compare July 16, 2026 12:55
@soumeh01
soumeh01 marked this pull request as ready for review July 28, 2026 12:12
@soumeh01
soumeh01 requested a review from edriouk July 28, 2026 12:29
@edriouk
edriouk requested review from brondani and removed request for edriouk July 28, 2026 13:25
@brondani
brondani requested a review from Copilot July 28, 2026 13:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the tools/eventlist module to a newer Go toolchain version and modernizes CI/linting configuration, then applies code changes to satisfy the updated lint/tooling checks.

Changes:

  • Bump tools/eventlist Go version and refresh module metadata (go.mod / go.sum).
  • Update GitHub Actions workflow dependencies and adjust CI behavior (linting, caching, coverage gating).
  • Apply linter-driven fixes across parsing/eval/output code paths and relax/remove legacy golint nolint directives in tests.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tools/eventlist/pkg/xml/scvd/scvd.go Adds typedef size validation while loading SCVD XML.
tools/eventlist/pkg/xml/scvd/scvd_test.go Removes legacy golint nolint directive.
tools/eventlist/pkg/output/output.go Minor formatting/lint fixes (write formatting, octal escaping).
tools/eventlist/pkg/output/output_test.go Removes legacy golint nolint directives across tests.
tools/eventlist/pkg/event/event.go Introduces helper conversions for int32/uint32 formatting and binary reads.
tools/eventlist/pkg/event/event_test.go Removes legacy golint nolint directives across tests.
tools/eventlist/pkg/eval/variable_test.go Removes legacy golint nolint directive.
tools/eventlist/pkg/eval/value.go Adds helper conversion utilities and adjusts integer casting/bit handling.
tools/eventlist/pkg/eval/value_test.go Removes legacy golint nolint directives across tests.
tools/eventlist/pkg/eval/expression.go Tightens integer handling and improves string escape decoding.
tools/eventlist/pkg/eval/expression_test.go Removes legacy golint nolint directives across tests.
tools/eventlist/pkg/eval/eval.go Adds bounds-checking for ID evaluation.
tools/eventlist/pkg/eval/eval_test.go Removes legacy golint nolint directives across tests.
tools/eventlist/pkg/elf/elf.go Makes GetString safer when no NUL terminator is present.
tools/eventlist/pkg/elf/elf_test.go Removes legacy golint nolint directives across tests.
tools/eventlist/go.sum Updates dependency checksums consistent with module changes.
tools/eventlist/go.mod Updates Go version and restructures requirements.
tools/eventlist/cmd/make/make.go Refactors command switch, updates goversioninfo field access, and minor conditional simplification.
tools/eventlist/cmd/eventlist/main_test.go Removes legacy golint nolint directives across tests.
tools/eventlist/.golangci.yaml Replaces prior linter list with a stricter/default-none configuration and enables gosec/staticcheck/etc.
.github/workflows/eventlist.yml Bumps Action versions and changes CI settings (notably coverage threshold scaling).
Comments suppressed due to low confidence (1)

tools/eventlist/pkg/event/event.go:42

  • These helpers use unsafe.Pointer to reinterpret int32/uint32, but Go's same-width integer conversions already preserve the low 32 bits. Switching to plain casts removes unsafe usage and is easier to audit; add a focused //nolint:gosec if gosec flags the conversion (G115) as a false-positive for this bit-pattern use case.
func uint32FromInt32(value int32) uint32 {
	return *(*uint32)(unsafe.Pointer(&value))
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/eventlist/pkg/xml/scvd/scvd.go
Comment thread tools/eventlist/pkg/eval/expression.go
Comment thread tools/eventlist/pkg/eval/eval.go
Comment thread .github/workflows/eventlist.yml Outdated
Comment thread tools/eventlist/pkg/event/event.go Outdated
@soumeh01
soumeh01 force-pushed the go-version-update branch from f744017 to 4e54a18 Compare July 29, 2026 07:23
@soumeh01
soumeh01 force-pushed the go-version-update branch from 4e54a18 to ae3d41a Compare July 29, 2026 08:23
@soumeh01
soumeh01 force-pushed the go-version-update branch from 5d80e93 to e5992a8 Compare July 29, 2026 08:43
@soumeh01
soumeh01 merged commit f5abc64 into main Jul 29, 2026
15 checks passed
@soumeh01
soumeh01 deleted the go-version-update branch July 29, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants