Updated go version from 1.20 to 1.26 - #165
Merged
Merged
Conversation
soumeh01
force-pushed
the
go-version-update
branch
from
July 16, 2026 12:49
3c2337a to
a064709
Compare
Contributor
Test Results 3 files 21 suites 0s ⏱️ Results for commit 201c75b. ♻️ This comment has been updated with latest results. |
soumeh01
force-pushed
the
go-version-update
branch
from
July 16, 2026 12:55
a064709 to
2c80c5c
Compare
There was a problem hiding this comment.
Pull request overview
This pull request updates the tools/eventlist module to a newer Go toolchain version and modernizes CI/linting configuration, then applies code changes to satisfy the updated lint/tooling checks.
Changes:
- Bump
tools/eventlistGo version and refresh module metadata (go.mod/go.sum). - Update GitHub Actions workflow dependencies and adjust CI behavior (linting, caching, coverage gating).
- Apply linter-driven fixes across parsing/eval/output code paths and relax/remove legacy
golintnolint directives in tests.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/eventlist/pkg/xml/scvd/scvd.go | Adds typedef size validation while loading SCVD XML. |
| tools/eventlist/pkg/xml/scvd/scvd_test.go | Removes legacy golint nolint directive. |
| tools/eventlist/pkg/output/output.go | Minor formatting/lint fixes (write formatting, octal escaping). |
| tools/eventlist/pkg/output/output_test.go | Removes legacy golint nolint directives across tests. |
| tools/eventlist/pkg/event/event.go | Introduces helper conversions for int32/uint32 formatting and binary reads. |
| tools/eventlist/pkg/event/event_test.go | Removes legacy golint nolint directives across tests. |
| tools/eventlist/pkg/eval/variable_test.go | Removes legacy golint nolint directive. |
| tools/eventlist/pkg/eval/value.go | Adds helper conversion utilities and adjusts integer casting/bit handling. |
| tools/eventlist/pkg/eval/value_test.go | Removes legacy golint nolint directives across tests. |
| tools/eventlist/pkg/eval/expression.go | Tightens integer handling and improves string escape decoding. |
| tools/eventlist/pkg/eval/expression_test.go | Removes legacy golint nolint directives across tests. |
| tools/eventlist/pkg/eval/eval.go | Adds bounds-checking for ID evaluation. |
| tools/eventlist/pkg/eval/eval_test.go | Removes legacy golint nolint directives across tests. |
| tools/eventlist/pkg/elf/elf.go | Makes GetString safer when no NUL terminator is present. |
| tools/eventlist/pkg/elf/elf_test.go | Removes legacy golint nolint directives across tests. |
| tools/eventlist/go.sum | Updates dependency checksums consistent with module changes. |
| tools/eventlist/go.mod | Updates Go version and restructures requirements. |
| tools/eventlist/cmd/make/make.go | Refactors command switch, updates goversioninfo field access, and minor conditional simplification. |
| tools/eventlist/cmd/eventlist/main_test.go | Removes legacy golint nolint directives across tests. |
| tools/eventlist/.golangci.yaml | Replaces prior linter list with a stricter/default-none configuration and enables gosec/staticcheck/etc. |
| .github/workflows/eventlist.yml | Bumps Action versions and changes CI settings (notably coverage threshold scaling). |
Comments suppressed due to low confidence (1)
tools/eventlist/pkg/event/event.go:42
- These helpers use unsafe.Pointer to reinterpret int32/uint32, but Go's same-width integer conversions already preserve the low 32 bits. Switching to plain casts removes unsafe usage and is easier to audit; add a focused //nolint:gosec if gosec flags the conversion (G115) as a false-positive for this bit-pattern use case.
func uint32FromInt32(value int32) uint32 {
return *(*uint32)(unsafe.Pointer(&value))
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
soumeh01
force-pushed
the
go-version-update
branch
from
July 29, 2026 07:23
f744017 to
4e54a18
Compare
soumeh01
force-pushed
the
go-version-update
branch
from
July 29, 2026 08:23
4e54a18 to
ae3d41a
Compare
soumeh01
force-pushed
the
go-version-update
branch
from
July 29, 2026 08:43
5d80e93 to
e5992a8
Compare
brondani
approved these changes
Jul 29, 2026
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that the linter fixes were generated with AI assistance.