Repository navigation
docs: tidy the READMEs for amdl 2.0 - #22
Merged
Merged
Conversation
The root README now says what the repo is, the shortest way to run it (amdl desktop app, Docker or Linux host, Cloudflare), the release assets and what differs from upstream. The manager README drops the nightly.link, build-manager-qemu and AppleMusicDecrypt text, documents payload pinning and -update-wrapper. The QEMU READMEs no longer repeat the root's launcher notes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: LYJW131 <153256373+LYJW131@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+74
to
+76
| By default the manager installs the newest `build-lite` artifact on `lite` | ||
| (`wrapper-lite-linux-x86_64.zip`, `…-aarch64.zip` on arm64) into `data/wrapper/`, | ||
| recording where it came from in `data/wrapper/.payload-source`. To run a fixed |
There was a problem hiding this comment.
🔍 Arm64 payload is not published
The documented arm64 payload has no matching build-lite artifact. The manager constructs its URL, but the workflow only uploads x86_64; arm64 users need the documented QEMU route.
Was this helpful? React with 👍 or 👎 to provide feedback.
Comment on lines
+27
to
+37
| git clone -b lite https://github.com/AMDL-Web/wrapper | ||
| cd wrapper/manager | ||
| docker compose up -d # API on localhost:8080; the container is privileged | ||
| ``` | ||
|
|
||
| Without Docker (Linux x86_64, user namespaces and chroot available): | ||
|
|
||
| ```shell | ||
| cd wrapper/manager | ||
| go build -o wrapper-manager . | ||
| ./wrapper-manager -host 0.0.0.0 -port 8080 |
There was a problem hiding this comment.
🟥 Quickstart exposes unauthenticated account API
Following either quickstart exposes wrapper-manager beyond localhost. Docker publishes 8080:8080 on every interface, and the native command binds 0.0.0.0. Anyone who reaches the port can read /token and manage accounts.
Was this helpful? React with 👍 or 👎 to provide feedback.
…blished Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: LYJW131 <153256373+LYJW131@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the root README (what it is, three ways to run it, release assets, differences from upstream), brings manager/ and the QEMU READMEs in line with the code (payload pinning, -update-wrapper, release assets, no stale nightly.link/build-manager-qemu text).
Docs only; every command was checked against the code or workflows.
🤖 Generated with Claude Code