Skip to content

ci(manager): boot the guest just built before uploading it #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LYJW131 merged 2 commits into from
Nov 3, 2026
Merged

ci(manager): boot the guest just built before uploading it #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44cdb56
ci(manager): boot the guest just built before uploading it
LYJW131 Nov 3, 2026
f84c2d1
ci(manager): use the guest boot action from amdl's dev branch
LYJW131 Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/manager.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,17 @@ jobs:
./guest/build.sh dist-guest
CREATE_DATA_IMG=1 ./guest/build.sh dist-guest

# Boots the guest just built in QEMU the way amdl's desktop app does,
# with amdl's own code (internal/wrapperhost, TestGuestBoot): the manager
# arguments must reach init, the guest must have network, download its
# pinned payload with the digest checked, and the manager must answer
# /status. A guest that does not is never uploaded for amdl to pin.
- name: Boot the guest
uses: AMDL-Web/apple-music-downloader/.github/actions/guestboot@dev
with:
checkout: dev

@devin-ai-integration devin-ai-integration Bot Nov 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Boot gate passes without booting guest

With checkout: dev, the action runs against a branch without TestGuestBoot. Its filtered go test succeeds with no matching test, so a broken guest can be uploaded.

Learn more

The external action is loaded from ci/gates, but its checkout input separately selects the amdl source branch for go test. At this revision, dev lacks TestGuestBoot; Go still exits successfully when a -run filter matches no tests. The upload step therefore runs without testing the built guest.

Example: A manager guest with nonworking network reaches this step. The action checks out dev, runs no boot test, returns success, and uploads that guest instead of rejecting it.

Recommended fix: Select ci/gates for checkout while the boot test exists only there. When moving to dev, verify that both the action and TestGuestBoot are present on that branch; make the action fail when the named test did not run.

Suggested change
checkout: dev
checkout: ci/gates

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

guest-dir: ${{ github.workspace }}/manager/dist-guest

- name: Upload guest assets
uses: actions/upload-artifact@v4
with:
Expand Down
Loading