Prefer IVF-PQ compute_similarity blockDim=512 on AMD (gfx1100) - #7
Open
konkolchin wants to merge 1 commit into
Open
Conversation
Hardcode gfx1100-friendly launch default (+28-36% search QPS vs stock auto-shrink on RX 7900 XTX; recall unchanged). DXC dashboard builds pick this up after rebuild. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockDim=512for IVF-PQcompute_similaritylaunches on HIP/AMD after stock occupancy auto-shrink, which under-sizes blocks on RDNA3 (gfx1100).IVF_PQm=32, SIFT-1M): ~+21–26% search QPS at nprobe 8/16/32 vs stock heuristic, recall@10 unchanged; optional envHIPVS_IVF_PQ_BLOCK_THREADSstill overrides when set.Context
results/lib_bench/LAUNCH_KNOBS.md,FILLED_pq_m32.md).__HIP_PLATFORM_AMD__) insidecompute_similarity_select.Test plan
INDEX_TYPE=IVF_PQ M=32— stderr showsblock_threads=512; nprobe=32 QPS ~270k vs ~217k stocklibcuvsfor target AMD arch and run existing IVF-PQ gtests / neighbors benches if available